From: Vince Weaver <vincent.weaver@maine.edu>
To: Dave Jones <davej@redhat.com>
Cc: trinity@vger.kernel.org
Subject: Re: [patch] perf_event_open more likely tracepoint values
Date: Fri, 15 Nov 2013 15:45:44 -0500 (EST) [thread overview]
Message-ID: <alpine.DEB.2.10.1311151544140.12594@vincent-weaver-1.um.maine.edu> (raw)
In-Reply-To: <20131114173352.GA5855@redhat.com>
On Thu, 14 Nov 2013, Dave Jones wrote:
> On Thu, Nov 14, 2013 at 12:35:27PM -0500, Vince Weaver wrote:
>
> > Tracepoint ids tend to be relatively small (less than 1024 or so).
> > This change makes it more likely to hit valid ones.
> >
> > Once the fix to avoid the troublesome 0x18 (irq_work_exit)
> > tracepoint gets into the kernel maybe we can start stressing
> > things with trinity again.
>
> applied, though fyi, this (and some other boolean choices) could
> be shorter with just
>
> if (rand_bool())
> foo
> else
> bar
>
> guess it depends if you foresee adding further case's though.
I wasn't sure of rand_bool() was only meant for setting boolean flag
variables or if it should be also used as the generic "choose one of two
options" selector.
I'll start using it instead of rand()%2 in future patches.
Vince
prev parent reply other threads:[~2013-11-15 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 17:35 [patch] perf_event_open more likely tracepoint values Vince Weaver
2013-11-14 17:33 ` Dave Jones
2013-11-15 20:45 ` Vince Weaver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1311151544140.12594@vincent-weaver-1.um.maine.edu \
--to=vincent.weaver@maine.edu \
--cc=davej@redhat.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).