From: Tommi Rantala <tt.rantala@gmail.com>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH] fix off-by-one in dump_childnos()
Date: Sun, 16 Apr 2017 22:35:21 +0300 [thread overview]
Message-ID: <CA+ydwtoMbPVFhoD+A3od_DMWAn2+QUG0AP=-AuRZ6uo2zRSjBw@mail.gmail.com> (raw)
In-Reply-To: <20170416183431.axmhqtnea3ebjiek@codemonkey.org.uk>
2017-04-16 21:34 GMT+03:00 Dave Jones <davej@codemonkey.org.uk>:
> On Sun, Apr 16, 2017 at 09:29:14PM +0300, Tommi Rantala wrote:
> > Fixes a segfault:
> >
> > ## pids: (60 active)
> > 0-7: 0 0 0 0 0 0 0 0
> > 8-15: 0 0 0 0 0 0 0 0
> > 16-23: 0 0 0 0 0 0 0 0
> > 24-31: 0 0 0 0 0 0 0 0
> > 32-39: 0 11081 11082 11083 11084 11085 11086 11087
> > 40-47: 11088 11089 11090 11091 11093 11094 11095 11096
> > 48-55: 11097 11098 11099 11100 11101 11102 0 0
> > Segmentation fault
>
> Applied. If you're seeing that though, that's indicative of a bigger
> problem (that we corrupted the pid table, or lost track of a child proc.).
Yea, I believe it was just about to exit anyways after the debug output.
> I've not seen that happen in about a year, does it happen often for you?
I was testing trinity in some minimal busybox & qemu environment, and
saw it a few times.
Now that I try it again, cannot reproduce the segfault anymore...
All the trinity processes have read-write access to the pids[] array?
So any one of them could corrupt the memory...?
-Tommi
prev parent reply other threads:[~2017-04-16 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 18:29 [PATCH] fix off-by-one in dump_childnos() Tommi Rantala
2017-04-16 18:34 ` Dave Jones
2017-04-16 19:35 ` Tommi Rantala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+ydwtoMbPVFhoD+A3od_DMWAn2+QUG0AP=-AuRZ6uo2zRSjBw@mail.gmail.com' \
--to=tt.rantala@gmail.com \
--cc=davej@codemonkey.org.uk \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).