From: Dave Jones <davej@codemonkey.org.uk>
To: Praveen Pandey <praveen@linux.vnet.ibm.com>
Cc: trinity@vger.kernel.org, sachinp@in.ibm.com
Subject: Re: [PATCH] Patch : enable tool as make -p take an arg for seconds
Date: Tue, 4 Aug 2015 19:44:33 -0400 [thread overview]
Message-ID: <20150804234433.GA20116@codemonkey.org.uk> (raw)
In-Reply-To: <1438159549-4119-1-git-send-email-praveen@linux.vnet.ibm.com>
On Wed, Jul 29, 2015 at 02:15:49PM +0530, Praveen Pandey wrote:
> diff --git a/Documentation/TODO b/Documentation/TODO
> index 73ea04a..108ee9c 100644
> --- a/Documentation/TODO
> +++ b/Documentation/TODO
> @@ -228,7 +228,7 @@
> - if we find a blocking fd, check if it's a socket, and shutdown() it.
> (tricky: we need to do the shutdown in the main process, and then tell other children)
>
> -* make -p take an arg for seconds
> +* make -p take an arg for seconds --- DONE
I'm not sure this feature actually adds any value any more.
I don't recall what I was thinking back when I added that TODO item,
but it probably came from a time long before Trinity had multiple child processes.
Unless anyone has a compelling reason for this, I'd say just drop it.
Dave
prev parent reply other threads:[~2015-08-04 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 8:45 [PATCH] Patch : enable tool as make -p take an arg for seconds Praveen Pandey
2015-08-04 23:44 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804234433.GA20116@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=praveen@linux.vnet.ibm.com \
--cc=sachinp@in.ibm.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).