From: Dave Jones <davej@redhat.com>
To: trinity@vger.kernel.org
Subject: Re: breakage on master.
Date: Fri, 6 Jun 2014 13:54:01 -0400 [thread overview]
Message-ID: <20140606175401.GA22525@redhat.com> (raw)
In-Reply-To: <20140603205411.GA32313@redhat.com>
On Tue, Jun 03, 2014 at 04:54:11PM -0400, Dave Jones wrote:
> I just committed some code changing how logging works so that the
> post-mortem dumping has a possibility of actually working.
> It looks a lot closer to how I want it to be, but it does seem to have
> a number of bugs right now which may take a couple days to nail down.
The good news: That work is pretty much done. Next week I'll add
the interesting parts to tainted_postmortem().
It's actually really handy to be able to do something like
output(0, "%s\n", rec->prebuffer);
and get what would have been dumped to the screen/logs if you hadn't
passed in -q or -l off.
The bad news: While working on this stuff the last few days I found
a bunch of other bugs that I've also committed fixes/workarounds for.
With that stuff out of the way, I'm seeing pretty regular corruption
of the pid map. This *might* be the bugs that Michael reported last
week has become easier to hit, or it might be that this weeks hacking
has introduced some new damage.
So far I've not had luck tracking it down, so I've pushed out everything
I had pending in the hopes someone else spots something obvious.
When it fails, it's interesting to note that the corrupted values in
the pid map are nearly always the same. I see either -943208505 or
943208504. Which are 0xc7c7c7c7 and 0x38383838.
Which smells like something has called rand32() -> rept8 on a
stale/wrong pointer somewhere, or we're walking past the end of a buffer.
(though it's curious that that function would nearly always pick those values,
so maybe my guess is off).
Dave
prev parent reply other threads:[~2014-06-06 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 20:54 breakage on master Dave Jones
2014-06-06 17:54 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606175401.GA22525@redhat.com \
--to=davej@redhat.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).