From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: tt.rantala@gmail.com, netdev@vger.kernel.org, davej@redhat.com,
trinity@vger.kernel.org, linux-kernel@vger.kernel.org,
therbert@google.com, maze@google.com
Subject: Re: [PATCH] ip_tunnel: fix panic in ip_tunnel_xmit()
Date: Mon, 03 Feb 2014 13:03:09 -0800 (PST) [thread overview]
Message-ID: <20140203.130309.1340651554312620948.davem@davemloft.net> (raw)
In-Reply-To: <1391460734.28432.111.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 03 Feb 2014 12:52:14 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Setting rt variable to NULL at the beginning of ip_tunnel_xmit()
> missed possible use of this variable as a scratch value.
>
> Also fixes a possible dst leak in tunnel_dst_check() :
> If we had to call tunnel_dst_reset(), we forgot to
> release the reference on dst.
>
> Merges tunnel_dst_get()/tunnel_dst_check() into
> a single tunnel_rtable_get() function for clarity.
>
> Many thanks to Tommi for his report and tests.
>
> Fixes: 7d442fab0a67 ("ipv4: Cache dst in tunnels)"
> Reported-by: Tommi Rantala <tt.rantala@gmail.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Tested-by: Tommi Rantala <tt.rantala@gmail.com>
> Cc: Tom Herbert <therbert@google.com>
> Cc: Maciej ¯enczykowski <maze@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2014-02-03 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 20:11 BUG ip_dst_cache (Not tainted): Poison overwritten Tommi Rantala
2014-01-31 20:57 ` Eric Dumazet
2014-02-01 20:29 ` Tommi Rantala
2014-02-03 19:35 ` Tommi Rantala
2014-02-03 20:52 ` [PATCH] ip_tunnel: fix panic in ip_tunnel_xmit() Eric Dumazet
2014-02-03 21:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203.130309.1340651554312620948.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=trinity@vger.kernel.org \
--cc=tt.rantala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).