From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nayna Jain <nayna@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de,
tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net, patrickc@us.ibm.com
Subject: Re: [PATCH v2 2/4] tpm: define __wait_for_tpm_stat to specify variable polling sleep time
Date: Fri, 15 Sep 2017 08:20:43 -0700 [thread overview]
Message-ID: <20170915152043.2qr7ow4pbmrfnzt3@linux.intel.com> (raw)
In-Reply-To: <20e706f4-d7c2-1d20-4268-129275ab3fc9@linux.vnet.ibm.com>
On Fri, Sep 15, 2017 at 06:07:26PM +0530, Nayna Jain wrote:
>
>
> On 09/13/2017 06:28 AM, Jarkko Sakkinen wrote:
> > On Wed, Sep 06, 2017 at 08:56:37AM -0400, Nayna Jain wrote:
> > > The existing wait_for_tpm_stat() checks the chip status before
> > > sleeping for 5 msec in a polling loop. For some functions although
> > > the status isn't ready immediately, the status returns extremely
> > > quickly. Waiting for 5 msec causes an unnecessary delay. An
> > > example is the send() call in the tpms_tis driver.
> > >
> > > This patch defines __wait_for_tpm_stat(), allowing the caller
> > > to specify the polling sleep timeout value within the loop.
> > > The existing wait_for_tpm_stat() becomes a wrapper for this
> > > function.
> > >
> > > After this change, performance on a TPM 1.2 with an 8 byte
> > > burstcount for 1000 extends improved from ~14sec to ~10sec.
> > >
> > > Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
> > > Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
> > Please get rid of wait_for_tpm_stat() rather than further making it more
> > complex. It's hardware specific stuff. This function should not exist in
> > tpm-interface.c.
>
> I think I didn't understand the meaning of "get rid of wait_for_tpm_stat()".
> Do you mean to take care of it in driver specific file ?
> Can you please elaborate it ?
>
> Thanks & Regards,
> - Nayna
It's not a generic function. It's used only in tpm_tis and tpm-xenfront.
They should have their owen private functions for this. Here the sharing
of code makes zero sense.
/Jarkko
next prev parent reply other threads:[~2017-09-15 15:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 12:56 [PATCH v2 0/4] additional TPM performance improvements Nayna Jain
2017-09-06 12:56 ` [PATCH v2 3/4] tpm: reduce tpm_msleep() time in get_burstcount() Nayna Jain
2017-09-13 1:00 ` Jarkko Sakkinen
2017-09-15 12:40 ` Nayna Jain
2017-09-06 12:56 ` [PATCH 1/4] tpm: ignore burstcount to improve tpm_tis send() performance Nayna Jain
[not found] ` <20170906125643.5070-6-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-09-06 12:58 ` Nayna
[not found] ` <20170906125643.5070-1-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-09-06 12:56 ` [PATCH v2 " Nayna Jain
2017-09-06 16:12 ` Jason Gunthorpe
2017-09-13 18:52 ` [tpmdd-devel] " Ken Goldman
[not found] ` <3c418974-a4c7-518e-b218-f6373c10209e-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-09-13 19:01 ` Peter Huewe
2017-09-13 0:45 ` Jarkko Sakkinen
[not found] ` <20170912222010.ltm76m5vy2kupydi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-13 18:39 ` Peter Huewe
2017-09-13 23:10 ` Jarkko Sakkinen
2017-09-15 12:29 ` Nayna Jain
2017-09-15 15:19 ` Jarkko Sakkinen
2017-09-06 12:56 ` [PATCH v2 2/4] tpm: define __wait_for_tpm_stat to specify variable polling sleep time Nayna Jain
2017-09-13 0:58 ` Jarkko Sakkinen
2017-09-15 12:37 ` Nayna Jain
2017-09-15 15:20 ` Jarkko Sakkinen [this message]
2017-09-06 12:56 ` [PATCH v2 4/4] tpm: use tpm_msleep() value as max delay Nayna Jain
2017-09-13 0:47 ` Jarkko Sakkinen
2017-09-14 9:25 ` Nayna Jain
2017-09-14 12:28 ` Jarkko Sakkinen
2017-09-06 12:56 ` [PATCH 2/4] tpm: define __wait_for_tpm_stat to specify variable polling sleep time Nayna Jain
2017-09-06 12:58 ` Nayna
2017-09-07 16:18 ` [PATCH v2 0/4] additional TPM performance improvements Jarkko Sakkinen
2017-09-11 15:20 ` [tpmdd-devel] " Alexander.Steffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915152043.2qr7ow4pbmrfnzt3@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=patrickc@us.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).