From: "Michal Suchánek" <msuchanek@suse.de>
To: Christophe Ricard <christophe.ricard@gmail.com>,
linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
apronin@chromium.org
Subject: tpm: read burstcount from TPM_STS in one 32-bit transaction
Date: Tue, 25 Jul 2017 15:04:43 +0200 [thread overview]
Message-ID: <20170725150443.7cf8fc91@kitsune.suse.cz> (raw)
Hello,
in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one
32-bit transaction") you change reading of two 8-bit values to one
32bit read. This is obviously wrong wrt endianess unless the
underlying tpm_tis_read32 does endian conversion.
Looking at the implementation
static inline int tpm_tis_read32(struct tpm_tis_data *data, u32 addr,
u32 *result)
{
return data->phy_ops->read32(data, addr, result);
}
it calls read32 which has two implementations:
static const struct tpm_tis_phy_ops tpm_tcg = {
.read32 = tpm_tcg_read32,
static int tpm_tcg_read32(struct tpm_tis_data *data, u32 addr, u32
*result) {
struct tpm_tis_tcg_phy *phy = to_tpm_tis_tcg_phy(data);
*result = ioread32(phy->iobase + addr);
return 0;
}
static const struct tpm_tis_phy_ops tpm_spi_phy_ops = {
.read32 = tpm_tis_spi_read32,
static int tpm_tis_spi_read32(struct tpm_tis_data *data, u32 addr, u32
*result) {
int rc;
rc = data->phy_ops->read_bytes(data, addr, sizeof(u32), (u8
*)result); if (!rc)
*result = le32_to_cpu(*result);
return rc;
}
meaning that unless you are on LE where le32_to_cpu is a noop these
functions do completely different thing. So presumably this is
completely broken on BE.
Presumably only the SPI variant can be actually used with TPM devices
bolted on after the fact so it is more likely correct for obscure
hardware. Conseqently tpm_tcg_read32 should use
le32_to_cpu(ioread32(phy->iobase + addr)) in case somebody manages to
map a TPM into io-space on a BE machine.
Thanks
Michal
next reply other threads:[~2017-07-25 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 13:04 Michal Suchánek [this message]
2017-07-25 17:36 ` [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction James Bottomley
2017-07-25 18:17 ` Michal Suchánek
[not found] ` <20170725201758.230de968-6hIufAJW0g4CVLCxKZUutA@public.gmane.org>
2017-08-01 13:31 ` Jarkko Sakkinen
[not found] ` <1501004171.3689.25.camel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-08-01 15:59 ` George Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725150443.7cf8fc91@kitsune.suse.cz \
--to=msuchanek@suse.de \
--cc=apronin@chromium.org \
--cc=christophe.ricard@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).