From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, jgunthorpe@obsidianresearch.com
Subject: Re: [PATCH v3] tpm: vtpm_proxy: Suppress error logging when in closed state
Date: Thu, 1 Jun 2017 20:14:20 +0300 [thread overview]
Message-ID: <20170601171420.djihd2nst7j74rdh@intel.com> (raw)
In-Reply-To: <1495751353-28500-1-git-send-email-stefanb@linux.vnet.ibm.com>
On Thu, May 25, 2017 at 06:29:13PM -0400, Stefan Berger wrote:
> Suppress the error logging when the core TPM driver sends commands
> to the VTPM proxy driver and -EPIPE is returned in case the VTPM
> proxy driver is 'closed' (closed anonymous file descriptor). This
> error code is only returned by the send function and by tpm_transmit
> when the VTPM proxy driver is being used.
>
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> ---
> drivers/char/tpm/tpm-interface.c | 5 +++--
> drivers/char/tpm/tpm2-cmd.c | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> index d711186..d2b4df6 100644
> --- a/drivers/char/tpm/tpm-interface.c
> +++ b/drivers/char/tpm/tpm-interface.c
> @@ -430,8 +430,9 @@ ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space,
>
> rc = chip->ops->send(chip, (u8 *) buf, count);
> if (rc < 0) {
> - dev_err(&chip->dev,
> - "tpm_transmit: tpm_send: error %d\n", rc);
> + if (rc != -EPIPE)
> + dev_err(&chip->dev,
> + "%s: tpm_send: error %d\n", __func__, rc);
> goto out;
> }
>
> diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
> index 3ee6883..3a99643 100644
> --- a/drivers/char/tpm/tpm2-cmd.c
> +++ b/drivers/char/tpm/tpm2-cmd.c
> @@ -840,7 +840,7 @@ void tpm2_shutdown(struct tpm_chip *chip, u16 shutdown_type)
> /* In places where shutdown command is sent there's no much we can do
> * except print the error code on a system failure.
> */
> - if (rc < 0)
> + if (rc < 0 && rc != -EPIPE)
> dev_warn(&chip->dev, "transmit returned %d while stopping the TPM",
> rc);
> }
> --
> 2.4.3
>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkine@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkine@linux.intel.com>
/Jarkko
prev parent reply other threads:[~2017-06-01 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 22:29 [PATCH v3] tpm: vtpm_proxy: Suppress error logging when in closed state Stefan Berger
2017-05-30 4:51 ` Jarkko Sakkinen
2017-06-01 17:14 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601171420.djihd2nst7j74rdh@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).