From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Petr Vandrovec <petr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 0/4] Add support for TPM2 log reported via ACPI table
Date: Mon, 3 Apr 2017 22:11:54 +0300 [thread overview]
Message-ID: <20170403191154.77v5thdvlqiiagxl@intel.com> (raw)
In-Reply-To: <58DEC79F.6000805-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
On Fri, Mar 31, 2017 at 02:18:23PM -0700, Petr Vandrovec wrote:
> Jarkko Sakkinen wrote:
> > On Wed, Mar 29, 2017 at 12:43:20AM -0700, Petr Vandrovec wrote:
> > > Hi Peter,
> > >
> > > This series of 4 patches adds support for handling TPM2
> > > log when it is reported through ACPI TPM2 table, as
> > > described in latest TPM ACPI draft (Version 1.2, Revision 8,
> > > from February 27th, 2017).
> > >
> > > I've tested patch on x86 only - I do not have PPC64 system
> > > with TPM, and handling of endianness between tpm1_eventlog.c
> > > and tpm2_eventlog.c seems inconsistent: tpm1_eventlog.c uses
> > > be32_to_cpu() for all log fields on PPC64, while
> > > tpm2_eventlog.c uses log uses native endianness. If it
> > > is intentional, and PPC64 has TPM1 logs in big endian
> > > while TPM2 logs in native endianness, then 3rd patch
> > > needs to be amended.
> > >
> > > Four patches split task of improving TPM2 support into following
> > > subtasks:
> >
> > This cover letter is a bit chaotic. A cover letter should give an
> > understandable description of the what is done. Now you have a 2nd
> > version of commit messages here. This looks confusing.
>
> Hi Jarkko,
>
> sorry about that. I wanted to provide additional details in the cover
> letter. As far as understandable description, it is more or less covered in
> first paragraph. Would this summary work for you:
>
> This series adds support for handling TPM2 log when it is reported through
> ACPI TPM2 table, as described in latest TPM ACPI draft (Version 1.2,
> Revision 8, from February 27th, 2017).
>
> Second half of the series then improves support for TPM2 log parsing, so
> kernel does not crash when firmware provides TPM log in different format
> than 'Spec ID Event03', or if it uses Event03 format with more than 3
> hashes.
>
>
> Thanks,
> Petr
Great, thank you. I'll look into this in more detail after we are done
with 4.12.
/Jarkko
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
prev parent reply other threads:[~2017-04-03 19:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 7:43 [PATCH 0/4] Add support for TPM2 log reported via ACPI table Petr Vandrovec
[not found] ` <20170329074320.zcbuydd7iydaj3gr-WbvboCQVrrgDIl+Cyo8nDyLysJ1jNyTM@public.gmane.org>
2017-03-30 4:51 ` Nayna
[not found] ` <58DC8EBF.40700-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-03-30 8:13 ` Petr Vandrovec
[not found] ` <58DCBE41.3060507-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2017-03-31 14:43 ` Ken Goldman
2017-04-03 18:31 ` Nayna
2017-03-31 8:15 ` Jarkko Sakkinen
2017-03-31 18:39 ` Jarkko Sakkinen
[not found] ` <20170331183923.mmtggrj2bcybwajz-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-03-31 21:18 ` Petr Vandrovec
[not found] ` <58DEC79F.6000805-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2017-04-03 19:11 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403191154.77v5thdvlqiiagxl@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=petr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).