From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: "Jérémy Lefaure"
<jeremy.lefaure-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions
Date: Tue, 21 Mar 2017 10:03:53 +0200 [thread overview]
Message-ID: <20170321080353.oh2apppp37nchuw7@intel.com> (raw)
In-Reply-To: <20170317015133.2269-1-jeremy.lefaure-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org>
On Thu, Mar 16, 2017 at 09:51:33PM -0400, Jérémy Lefaure wrote:
> When PM_SLEEP is disabled crb_pm_suspend and crb_pm_resume are not used by
> SET_SYSTEM_SLEEP_PM_OPS even if PM is enabled:
>
> drvers/char/tpm/tpm_crb.c:540:12: warning: ‘crb_pm_suspend’ defined but not
> used [-Wunused-function]
> static int crb_pm_suspend(struct device *dev)
> ^
> drivers/char/tpm/tpm_crb.c:551:12: warning: ‘crb_pm_resume’ defined but not
> used [-Wunused-function]
> static int crb_pm_resume(struct device *dev)
> ^
>
> The preprocessor condition should be on CONFIG_PM_SLEEP, not on CONFIG_PM.
> However, this patch fixes this warning by using __maybe_unused on function
> that are in the preprocessor condition.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Thanks. Please include also linux-kernel@vger.kernel.org in the future.
Reviewed-by: Jarkko Saskkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/tpm_crb.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
> index 324561845dc2..044afb73fdeb 100644
> --- a/drivers/char/tpm/tpm_crb.c
> +++ b/drivers/char/tpm/tpm_crb.c
> @@ -520,8 +520,7 @@ static int crb_acpi_remove(struct acpi_device *device)
> return 0;
> }
>
> -#ifdef CONFIG_PM
> -static int crb_pm_runtime_suspend(struct device *dev)
> +static int __maybe_unused crb_pm_runtime_suspend(struct device *dev)
> {
> struct tpm_chip *chip = dev_get_drvdata(dev);
> struct crb_priv *priv = dev_get_drvdata(&chip->dev);
> @@ -529,7 +528,7 @@ static int crb_pm_runtime_suspend(struct device *dev)
> return crb_go_idle(dev, priv);
> }
>
> -static int crb_pm_runtime_resume(struct device *dev)
> +static int __maybe_unused crb_pm_runtime_resume(struct device *dev)
> {
> struct tpm_chip *chip = dev_get_drvdata(dev);
> struct crb_priv *priv = dev_get_drvdata(&chip->dev);
> @@ -537,7 +536,7 @@ static int crb_pm_runtime_resume(struct device *dev)
> return crb_cmd_ready(dev, priv);
> }
>
> -static int crb_pm_suspend(struct device *dev)
> +static int __maybe_unused crb_pm_suspend(struct device *dev)
> {
> int ret;
>
> @@ -548,7 +547,7 @@ static int crb_pm_suspend(struct device *dev)
> return crb_pm_runtime_suspend(dev);
> }
>
> -static int crb_pm_resume(struct device *dev)
> +static int __maybe_unused crb_pm_resume(struct device *dev)
> {
> int ret;
>
> @@ -559,8 +558,6 @@ static int crb_pm_resume(struct device *dev)
> return tpm_pm_resume(dev);
> }
>
> -#endif /* CONFIG_PM */
> -
> static const struct dev_pm_ops crb_pm = {
> SET_SYSTEM_SLEEP_PM_OPS(crb_pm_suspend, crb_pm_resume)
> SET_RUNTIME_PM_OPS(crb_pm_runtime_suspend, crb_pm_runtime_resume, NULL)
> --
> 2.12.0
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
next prev parent reply other threads:[~2017-03-21 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 1:51 [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions Jérémy Lefaure
[not found] ` <20170317015133.2269-1-jeremy.lefaure-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org>
2017-03-21 8:03 ` Jarkko Sakkinen [this message]
[not found] ` <20170321080353.oh2apppp37nchuw7-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-03-21 22:05 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B543B122D-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-03-23 15:51 ` Jarkko Sakkinen
[not found] ` <20170323155117.w6zsewdxc6eeti4b-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-03-28 6:15 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B543C8D91-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-03-28 7:35 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321080353.oh2apppp37nchuw7@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=jeremy.lefaure-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).