From: Mark Brown <broonie@kernel.org>
To: Song Liu <song@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
tools@linux.kernel.org
Subject: Re: feature request: b4 am verifies SHA1 from the Fixes tag exists in current branch
Date: Fri, 18 Aug 2023 22:45:53 +0100 [thread overview]
Message-ID: <bf0db0f2-f7c6-4f0a-9a19-7d00f5fac0b6@sirena.org.uk> (raw)
In-Reply-To: <CAPhsuW4FOtZLa7S7pYWcvssNMjQxvrTkkUKentyu5A8Ppg6vGg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
On Fri, Aug 18, 2023 at 02:22:13PM -0700, Song Liu wrote:
> On Fri, Aug 18, 2023 at 2:14 PM Mark Brown <broonie@kernel.org> wrote:
> > Note that one of the most common sources of this error is Fixes: tags
> > that apply to non-upstream commits which amkees it hard for automation
> > to catch a commit that's unknown upstream (or at least requires fiddly
> > configuration).
> I think we can still have b4-am catch the issue when the SHA is not in
That'd be one useful approach, yes. Not saying don't do it, just that
there's gotchas.
> current branch? A rebase may still change the SHA later on, but a check
> at b4-am time should still catch some issues?
Indeed. A lot of people use something like Greg's scripts for this:
https://github.com/gregkh/gregkh-linux/tree/master/work/scripts
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-08-18 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 21:10 feature request: b4 am verifies SHA1 from the Fixes tag exists in current branch Song Liu
2023-08-18 21:14 ` Mark Brown
2023-08-18 21:22 ` Song Liu
2023-08-18 21:45 ` Mark Brown [this message]
2023-08-18 21:14 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf0db0f2-f7c6-4f0a-9a19-7d00f5fac0b6@sirena.org.uk \
--to=broonie@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=song@kernel.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).