From: Mark Brown <broonie@kernel.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools <tools@linux.kernel.org>
Subject: Unhelpful cover letter default for single patch serieses
Date: Fri, 28 Apr 2023 19:32:06 +0100 [thread overview]
Message-ID: <ZEwRJqjvbZGqpZpg@sirena.org.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
Hi,
When creating single patch serieses I repeately get tripped up by the
default cover letter behaviour with EDITME. I run
b4 prep <make a new branch>
<make kernel do thing>
b4 prep --auto-to-cc
see that --auto-to-cc did what I wanted then run my CI only to have b4
send fail afterwards due to the EDITMEs left in the cover letter which I
never saw since I don't want a cover for a single patch series and
--auto-to-cc did the right thing.
Perhaps this could be addressed by both changing the default cover
letter to not include the EDITMEs and switching the sense of the check
so that b4 send requires some magic string in the cover letter to send a
blank cover letter for a multi-patch series (NOCOVER or something)?
That'd mean that people would get no cover letter for single patch
serieses without any friction but still refuse to send a multi-patch
series without a cover letter unless the user actively intervenes.
Thanks,
Mark
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2023-04-28 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 18:32 Mark Brown [this message]
2023-05-01 15:37 ` Unhelpful cover letter default for single patch serieses Konstantin Ryabitsev
2023-05-01 15:42 ` Kernel.org Bugbot
2023-06-21 20:42 ` Kernel.org Bugbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEwRJqjvbZGqpZpg@sirena.org.uk \
--to=broonie@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).