From: Emil Velikov <emil.l.velikov@gmail.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@kernel.org
Subject: Re: [PATCH b4 v2] b4: add shell completion via python-shtab
Date: Thu, 28 Mar 2024 19:59:01 +0000 [thread overview]
Message-ID: <CACvgo52+Unse1ZCnSaVTNDJWqURgoqLswKbQhzxFWKFm7HW7Dw@mail.gmail.com> (raw)
In-Reply-To: <20240306-crouching-notorious-toad-acdafa@lemur>
On Wed, 6 Mar 2024 at 19:35, Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
>
> On Wed, Mar 06, 2024 at 12:03:31PM +0000, Emil Velikov wrote:
> > > My preference would be to go this route, because it doesn't create a new
> > > dependency on shtab but still lets packagers generate and ship the
> > > tab-completion content.
> > >
> >
> > The above solution can break in a number of cases and since there's no
> > CI, it can lurk broken for a while.
>
> Yes, but the same is true for any number of other things. Since this is an
> auxiliary feature, it's not really critical in my view.
>
> > - path changes from src/b4/ to ...
>
> I doubt this will change again -- I just did this as a large breaking feature
> to make pyproject.toml look less insane and I don't expect to do this again.
>
> > - parser function is moved from command.py, or command.py itself is renamed
> > - parser function is renamed
>
> These are possible, of course, but I doubt they are likely to happen. Even if
> it does, since it's an auxiliary feature, I don't really worry too much about
> introducing this regression.
>
> > Does that seem like a reasonable argument, or do you prefer the
> > standalone script approach?
>
> I still prefer to go with the CLI solution. I'm going to commit the script to
> misc (giving you proper attribution) and we'll try it out.
>
Ack, thanks for the patience and for landing upstream o/
-Emil
prev parent reply other threads:[~2024-03-28 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 16:59 [PATCH b4 v2] b4: add shell completion via python-shtab Emil Velikov via B4 Relay
2024-03-01 17:38 ` Konstantin Ryabitsev
2024-03-05 20:53 ` Konstantin Ryabitsev
2024-03-06 12:03 ` Emil Velikov
2024-03-06 19:35 ` Konstantin Ryabitsev
2024-03-28 19:59 ` Emil Velikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACvgo52+Unse1ZCnSaVTNDJWqURgoqLswKbQhzxFWKFm7HW7Dw@mail.gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=konstantin@linuxfoundation.org \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).