Linux maintainer tooling and workflows
 help / color / mirror / Atom feed

From: Johannes Zink <j.zink@pengutronix.de>
To: konstantin@linuxfoundation.org, users@linux.kernel.org,
	tools@linux.kernel.org
Cc: kernel@pengutronix.de
Subject: b4: Feature-Request: use salted hash for change-id instead of descriptive-name when using b4 prep
Date: Fri, 2 Jun 2023 10:00:11 +0200	[thread overview]
Message-ID: <837ab11e-e6c7-0dc6-9377-7889910aea09@pengutronix.de> (raw)

Hi,

first of all: thanks for creating and maintaining b4, it makes my daily kernel 
developer's life so much easier...

Accidentally I came across a (documented [1]) behaviour of b4 prep that is a 
little dangerous for my workflow: the descriptive-name is incorperated in the 
MessageID and the changeID in plaintext.

While for most applications this is probably fine, sometimes I use branch names 
along the line of "upstream-feature-for-$super_secret_customer_project" (or 
some other stupid branch names [2] - which it at least a bit funny if you know 
german...), which poses a risk of actually leaking information I do not want to 
be leaked.

I would like to ask if there is a possibility to change this to using a salted 
hash instead (salt is probably required due to rainbow table attacks) for 
messageID and changeID. If this would break some workflows, it could possibly 
be added as an optional command line argument for b4 prep?

Maybe this is just stupid-me, but I think other people might also benefit from 
this feature.

Cheers and again: thanks for your work
Johannes


[1] https://b4.docs.kernel.org/en/latest/contributor/prep.html
[2] 
https://lore.kernel.org/lkml/20230516-lustige-usb-phy-dinge-v2-1-3383a0de34ac@pengutronix.de/T/

-- 
Pengutronix e.K.                | Johannes Zink                  |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |

next             reply	other threads:[~2023-06-02  8:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02  8:00 Johannes Zink [this message]
2023-06-02 16:50 ` b4: Feature-Request: use salted hash for change-id instead of descriptive-name when using b4 prep Konstantin Ryabitsev
2023-06-05  6:10   ` Johannes Zink
2023-06-05  7:26     ` Mattijs Korpershoek
2023-06-05  7:32       ` Johannes Zink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837ab11e-e6c7-0dc6-9377-7889910aea09@pengutronix.de \
    --to=j.zink@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@linux.kernel.org \
    --cc=users@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).