Linux maintainer tooling and workflows
 help / color / mirror / Atom feed
From: Amjad Ouled-Ameur <aouledameur@baylibre.com>
To: tools@linux.kernel.org
Subject: b4 cover-letter in single patch submission
Date: Wed, 21 Sep 2022 14:23:18 +0200	[thread overview]
Message-ID: <3b1af982-83f1-d5ed-6df1-c654df481899@baylibre.com> (raw)

Hi,

I would like to open a discussion regarding b4 tool. I read in the b4 
doc that it will always

include a cover-letter even when sending a single patch [0]. This is 
regarded as a proactive

feature in case the submitter is later asked to split up the single the 
patch to many patches.

However, this can upset maintainers and reviewers when a single patch 
(that does not need

to be split up) is sent with a cover letter that would probably contain 
the same title and text

as the single patch.


My humble opinion is, adding a cover letter to a single patch should be 
an optional feature.

In this case, it might even be convenient to keep the change-id and 
changelog in the patch's

comment section.


[0]: 
https://b4.docs.kernel.org/en/latest/contributor/prep.html#what-if-i-only-have-a-single-patch


Regards,

Amjad


             reply	other threads:[~2022-09-21 12:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 12:23 Amjad Ouled-Ameur [this message]
2022-09-22 18:01 ` b4 cover-letter in single patch submission Konstantin Ryabitsev
2022-09-27  9:34   ` Amjad Ouled-Ameur
2022-10-04 10:08     ` Amjad Ouled-Ameur
2022-10-07 18:08       ` Konstantin Ryabitsev
2022-10-10  7:05         ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b1af982-83f1-d5ed-6df1-c654df481899@baylibre.com \
    --to=aouledameur@baylibre.com \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).