From: Nicolas Schier <n.schier@avm.de>
To: "Kernel.org Tools" <tools@linux.kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Nicolas Schier <n.schier@avm.de>
Subject: [PATCH b4] ty: auto-matching: Do not consume commit decorations
Date: Wed, 07 Feb 2024 09:25:35 +0100 [thread overview]
Message-ID: <20240207-ty-do-not-consume-commit-decorations-v1-1-995e5ff6666b@avm.de> (raw)
From: Nicolas Schier <nicolas@fjasle.eu>
Disable decoration when reading git log output for getting a list of git
commits.
Without '--no-decorate', commits that have branches or tags pointing to
them, will not be recognised by subject as get_all_commits will assume
that the decoration is part of the commits subject line, e.g.:
(HEAD -> main, tag: v1.142, origin/main) Dummy commit subject
instead of
Dummy commit subject
thus the former will never match the real patch subject line.
Signed-off-by: Nicolas Schier <nicolas@fjasle.eu>
---
Signed-off-by: Nicolas Schier <n.schier@avm.de>
---
b4/ty.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/b4/ty.py b/b4/ty.py
index 088933d..a8bdabf 100644
--- a/b4/ty.py
+++ b/b4/ty.py
@@ -164,7 +164,7 @@ def get_all_commits(gitdir: Optional[str], branch: str, since: str = '1.week',
usercfg = b4.get_user_config()
committer = usercfg['email']
- gitargs = ['log', '--committer', committer, '--no-abbrev', '--oneline', '--since', since, branch]
+ gitargs = ['log', '--committer', committer, '--no-abbrev', '--no-decorate', '--oneline', '--since', since, branch]
lines = b4.git_get_command_lines(gitdir, gitargs)
if not len(lines):
logger.debug('No new commits from the current user --since=%s', since)
---
base-commit: 2d94097cd5aedddd6985ec6154e0956293f4143b
change-id: 20240207-ty-do-not-consume-commit-decorations-302d8e54f95d
Best regards,
--
Nicolas Schier
next reply other threads:[~2024-02-07 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 8:25 Nicolas Schier [this message]
2024-02-07 9:33 ` [PATCH b4] ty: auto-matching: Do not consume commit decorations Nicolas Schier
2024-02-07 17:16 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207-ty-do-not-consume-commit-decorations-v1-1-995e5ff6666b@avm.de \
--to=n.schier@avm.de \
--cc=konstantin@linuxfoundation.org \
--cc=nicolas@fjasle.eu \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).