From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: tools@linux.kernel.org
Subject: Re: [PATCH 1/1] add --notes at git-show command to include notes in patches
Date: Thu, 1 Feb 2024 16:48:14 -0500 [thread overview]
Message-ID: <20240201-graceful-terrestrial-rhino-83c61f@lemur> (raw)
In-Reply-To: <20240131223054.371692-1-Frank.Li@nxp.com>
On Wed, Jan 31, 2024 at 05:30:54PM -0500, Frank Li wrote:
> I using notes to record patche's change log. b4 send will discard this. Add
> --notes options when create patches.
The biggest problem with using notes is that they are not currently preserved
by git-filter-repo:
https://github.com/newren/git-filter-repo/issues/22
Yes, there are some (hacky) workarounds to make this work, but even with them,
I am not comfortable with putting any information into notes that can just
suddenly be gone.
For now, I will keep this in the list of improvements, but I won't take this
patch until git-filter-repo does the right thing natively.
-K
prev parent reply other threads:[~2024-02-01 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 22:30 [PATCH 1/1] add --notes at git-show command to include notes in patches Frank Li
2024-02-01 21:48 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201-graceful-terrestrial-rhino-83c61f@lemur \
--to=konstantin@linuxfoundation.org \
--cc=Frank.Li@nxp.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).