From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Paul Moore <paul@paul-moore.com>
Cc: tools@linux.kernel.org
Subject: Re: Problems with patatt and stacked-git's patchset cover letter
Date: Fri, 22 Dec 2023 13:09:14 -0500 [thread overview]
Message-ID: <20231222-secret-thoughtful-zebu-fedba6@lemur> (raw)
In-Reply-To: <CAHC9VhRCTKD7qwm7u9EvudWkY9nw+CSS1HCOdr5c8OWBU1LCEg@mail.gmail.com>
On Thu, Dec 21, 2023 at 05:55:25PM -0500, Paul Moore wrote:
> Hi Konstantin,
>
> I didn't see a place to file issues on the patatt GH, and I'm not sure
> which mailing list was appropriate, if any, so I'm only sending this
> bug report to you; feel free to forward if appropriate.
Sounds good, cc'ing the tools list.
> I'm a little surprised to have run into this, as I believe there are
> other kernel devs using stacked-git, but perhaps I'm the only one
> using stacked-git in conjunction with patatt, who knows. The good
> news is that things seem to work just fine when sending single
> patches, or patchsets with no cover letter, however as soon as I try
> to send a patchset with a cover letter, i.e. 'stg email send --compose
> ...', I run into an error caused by a missing 'from' header:
>
> % stg email send --to=listname -a --compose
> ...
> error: `git send-email`: patatt: E:
> The following required headers not present: from
>
> ... which appears to be caused by the cover letter not starting with a
> "From <hash> <date>" line.
No, this means the actual From: header, like:
From: Foo Bar <foo.bar@example.com>
We require two headers to be present, From: and Subject:, because they make an
integral part of the git commit. Signing a message without them doesn't make
sense, which is why we err out.
Can you verify that stgit creates cover letters without the From: header?
Best wishes,
-K
next parent reply other threads:[~2023-12-22 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHC9VhRCTKD7qwm7u9EvudWkY9nw+CSS1HCOdr5c8OWBU1LCEg@mail.gmail.com>
2023-12-22 18:09 ` Konstantin Ryabitsev [this message]
2023-12-22 22:20 ` Problems with patatt and stacked-git's patchset cover letter Paul Moore
2024-01-08 20:45 ` Konstantin Ryabitsev
2024-02-06 21:00 ` Paul Moore
2024-02-06 21:12 ` Paul Moore
2024-02-13 17:38 ` Paul Moore
2024-02-14 14:13 ` Konstantin Ryabitsev
2024-02-14 14:56 ` Konstantin Ryabitsev
2024-02-15 21:55 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222-secret-thoughtful-zebu-fedba6@lemur \
--to=konstantin@linuxfoundation.org \
--cc=paul@paul-moore.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).