From: Joel Granados <j.granados@samsung.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Kernel.org Tools <tools@linux.kernel.org>
Subject: Re: [PATCH b4] ez: Add a --web arg to force web endpoint
Date: Wed, 2 Aug 2023 09:30:29 +0200 [thread overview]
Message-ID: <20230802073029.gkles6alt4g6gy5c@localhost> (raw)
In-Reply-To: <20230801-giggly-postnasal-707142@meerkat>
[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]
On Tue, Aug 01, 2023 at 12:14:22PM -0400, Konstantin Ryabitsev wrote:
> On Tue, Aug 01, 2023 at 05:03:36PM +0200, Joel Granados via B4 Relay wrote:
> > From: Joel Granados <j.granados@samsung.com>
> >
> > Make it easier to prefer going through the web endpoint by adding an
> > argument that will force this path. This is for users that want to use
> > B4 for preparing and sharing patchsets over mail and need an argument to
> > activate the web endpoint whenever needed, but want to default to smtp
> > server for the rest.
>
> Okay, that looks good to me, but can you please make two changes:
>
> > @@ -330,6 +330,8 @@ def setup_parser() -> argparse.ArgumentParser:
> > help='Initiate a new web authentication request')
> > ag_sendh.add_argument('--web-auth-verify', dest='auth_verify', metavar='VERIFY_TOKEN',
> > help='Submit the token received via verification email')
> > + ag_sendh.add_argument('--web', dest='send_web', action='store_true', default=False,
> > + help="Force the send command to go through the web endpoint")
>
> 1. It doesn't really belong in this argument group (it's just for
> setting up authentication and says so in the title). You can just put this
totally missed that :), thx for the feedback
> switch with the main arguments, perhaps as the last entry.
I have added it to the main args under --no-stdin.
Now that it is in the main args, I'll change the argument documentation
from "Force the send command to go through the web endpoint" to "Force
going through the web endpoint".
> 2. Call it --use-web-endpoint instead of just --web
sure thing
>
> Thanks!
>
> -K
--
Joel Granados
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-08-02 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 15:03 [PATCH b4] ez: Add a --web arg to force web endpoint Joel Granados via B4 Relay
2023-08-01 16:14 ` Konstantin Ryabitsev
2023-08-02 7:30 ` Joel Granados [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802073029.gkles6alt4g6gy5c@localhost \
--to=j.granados@samsung.com \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).