From: Christian Brauner <brauner@kernel.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@linux.kernel.org
Subject: Re: Picking up changed commit subjects when generating thank you messages & patch list generation
Date: Wed, 12 Jul 2023 20:58:32 +0200 [thread overview]
Message-ID: <20230712-nahegehen-stabil-41cfd48e565c@brauner> (raw)
In-Reply-To: <20230712-mulch-french-2788cd@meerkat>
On Wed, Jul 12, 2023 at 02:33:18PM -0400, Konstantin Ryabitsev wrote:
> On Tue, Jul 11, 2023 at 12:05:44PM +0200, Christian Brauner wrote:
> > Hey everyone,
> >
> > As always, very happy about b4!
> >
> > I have two features requests:
>
> bugbot on
>
> > (1) Automatically picking up changed commit subject lines
> > When applying series via shazam or am commit message subjects
> > sometimes need to be tweaked afterwards. But while b4 ty picks up
> > commit hash changes caused by e.g., git commit --amend it doesn't
> > pick up the changed subject.
> >
> > For example, the patch originally sent with commit subject "aaa" got
> > applied. Afterwards it was amended to "bbb". But b4 ty would still
> > generate:
> >
> > [1/1] aaa
> > https://git.kernel.org/vfs/vfs/c/7b2edd278691
> >
> > in the thank you letter.
>
> I can see arguments both for and against it. Since we are responding to the
> original submission, it makes sense to me to use the original patch subjects.
> However, I will consider how to best approach this situation.
>
> > (2) Let b4 support generating a patch list for a specified range of commits
> > Sometimes there are scenarios where it would be helpful to let b4
> > generate a list of applied commits for a range of commits (even if
> > not under direct control of b4):
> >
> > [01/92] subsystem1: long
> > https://git.kernel.org/vfs/vfs/c/ead310563ad2
> > [02/92] subsystem2: long
> > .
> > .
> > .
> > [92/92] subsystem92: list
> > https://git.kernel.org/vfs/vfs/c/f42faf14b838
> >
> > that can then be copy-pasted into a ty message.
> >
> > b4 has all the nice info and gitconfig options such as:
> > thanks-am-template, thanks-treename, thanks-commit-url-mask that
> > would make this just ultra useful.
>
> So, you just want a "summary of all commits" from an arbitrary range, using
> the template? Do we leave To/Cc fields blank, or populate them with all the
> addresses that we could match either via b4 tracking or via commit trailers?
Could this be config option?
next prev parent reply other threads:[~2023-07-12 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 10:05 Picking up changed commit subjects when generating thank you messages & patch list generation Christian Brauner
2023-07-12 18:33 ` Konstantin Ryabitsev
2023-07-12 18:58 ` Christian Brauner [this message]
2023-07-12 18:39 ` Kernel.org Bugbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712-nahegehen-stabil-41cfd48e565c@brauner \
--to=brauner@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).