From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Tools <tools@linux.kernel.org>, Christian Brauner <brauner@kernel.org>
Subject: Re: b4: send: support git notes per patch
Date: Tue, 28 Mar 2023 14:15:49 +0200 [thread overview]
Message-ID: <19f8574c-d743-cd8e-4b61-cb93a02f844a@tessares.net> (raw)
In-Reply-To: <jx7vyqdj3qt2zwgsxh6hjac6osr52n2vcmkj2pg3elapcth62m@jtl27si2pa3g>
Hi Konstantin,
Thank you for your reply!
On 27/03/2023 23:18, Konstantin Ryabitsev wrote:
> On Mon, Mar 27, 2023 at 12:20:43PM +0200, Matthieu Baerts wrote:
>> Do you think "b4 send" could attach the "git notes" to the different
>> patches being sent, similar to what "git format-patch --notes" does?
>>
>> Personally, I find this quite useful: when you have a series with a
>> bunch of patches, it seems interesting to put a detailed changelog per
>> patch instead of putting everything in the cover-letter. It makes even
>> more sense when some people are only Cc with a few patches and not with
>> the whole series. I didn't find a way to do that with b4.
>>
>> But then, I guess we might need a workaround implemented or shipped with
>> b4 to preserve the notes when git filter-repo is used, no?
>
> Correct, I don't want to touch it until we stop blowing away git notes every
> time we run "b4 trailers".
It makes sense.
> BTW, another alternative to git notes it to add this info into the commit
> itself, e.g.:
>
> libfoo: update foo bar
>
> This updates foo bar.
>
> Signed-off-by: Dev E. Loper <dev@example.com>
>
> ---
>
> My notes about the patch here that will be preserved by "b4 send" and show
> up in the patches sent out, but because they are below "---", they aren't
> going to be part of the commit.
Ah yes, good idea, thank you!
I can use this technique if "git notes" are not supported.
>> PS: by chance if you can have a look at my patches/questions for 'b4
>> prep --fork-point', that would be nice :)
>
> I know that it's been sitting for a while, and I'm not ignoring it, just need
> to find a good stretch of time to dedicate to understanding the RFC set.
Oh sorry, I just noticed there was an up to date and well maintained
patchwork project for b4[1]. I will stop bothering you now that I can
see patches have not been dropped by accident!
(in short, for this RFC, I just wanted to understand why there was this
complexity in the code to find the base-branch when --fork-point was
given in argument instead of simply using it if it is valid)
Cheers,
Matt
[1] https://patchwork.kernel.org/project/tools/list/
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
prev parent reply other threads:[~2023-03-28 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 10:20 b4: send: support git notes per patch Matthieu Baerts
2023-03-27 21:18 ` Konstantin Ryabitsev
2023-03-28 12:15 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f8574c-d743-cd8e-4b61-cb93a02f844a@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=brauner@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).