From: Conor Dooley <conor@kernel.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>, tools@linux.kernel.org
Subject: Re: b4 shazam picking up the wrong author from patchwork/lore
Date: Fri, 10 Mar 2023 20:09:26 +0000 [thread overview]
Message-ID: <02704762-7a14-422b-8d26-b24c12ffd48c@spud> (raw)
In-Reply-To: <20230310192652.ymac3w2lucfdf34p@meerkat.local>
[-- Attachment #1: Type: text/plain, Size: 1813 bytes --]
On Fri, Mar 10, 2023 at 02:26:52PM -0500, Konstantin Ryabitsev wrote:
> On Fri, Mar 10, 2023 at 09:38:54AM -0800, Palmer Dabbelt wrote:
> > Conor just pointed out that 2a8db5ec4a28 ("RISC-V: Don't check text_mutex
> > during stop_machine") was listed as authored by him, despite having a From
> > in the message body. That usually works fine so I'm not sure
> > what happened here -- no big deal because neither of us really care about the
> > authorship on this one (and the SOBs are fine), but figured it'd be best to say
> > something in case it bites someone else.
> >
> > I merged the patch with
> >
> > b4 shazam -lts https://patchwork.kernel.org/project/linux-riscv/patch/20230303143754.4005217-1-conor.dooley@microchip.com/
> >
> > which is the way I usually do things. This is the first time I've noticed any
> > sort of issue like this.
>
> Ooh, very neat catch. This would only happen under the following conditions:
> - the message had to be patatt-signed
> - you had to have had the key to properly validate it
> - and, most importantly, there had to be mailman trailers in the message
Heh, I suppose that (plus it being me sending Palmer's patch) puts it
well into corner case territory!
> When all of this was true, we would re-trim the body to the size that was
> actually passing verification (using the l= parameter from the patatt
> signature), but this lost the in-body From/Subject headers (because they were
> moved into the actual message headers during verification). There were
> workarounds initially for this happening, but they stopped working right
> around 0.10.
>
> This is now fixed in master and backported to 0.12.y. I will hopefully push
> out a 0.12.2 some time today.
>
> Thank you for the report.
Thank you for fixing it!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-03-10 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 17:38 b4 shazam picking up the wrong author from patchwork/lore Palmer Dabbelt
2023-03-10 18:14 ` Conor Dooley
2023-03-10 19:26 ` Konstantin Ryabitsev
2023-03-10 19:32 ` Palmer Dabbelt
2023-03-10 20:09 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02704762-7a14-422b-8d26-b24c12ffd48c@spud \
--to=conor@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=palmer@dabbelt.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).