From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
Cc: martin.petersen@oracle.com, bostroesser@gmail.com,
michael.christie@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: target: Fixed multiple typos in multiple files
Date: Wed, 15 Nov 2023 11:12:53 -0500 [thread overview]
Message-ID: <yq17cmj10bl.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20231023105915.29482-1-m.muzzammilashraf@gmail.com> (Muhammad Muzammil's message of "Mon, 23 Oct 2023 15:59:15 +0500")
Hi Muhammad,
> - * CID we do connection reinstatement. Currently we dont not
> + * CID we do connection reinstatement. Currently we don't not
"Currently we don't not" does not parse. Fixing misspelled words in
isolation is not necessarily an improvement. The criteria should be
whether the entire sentence or comment becomes easier to read.
> - * status, with the sense key set to ILLEGAL REQUEST,and the additonal
> + * status, with the sense key set to ILLEGAL REQUEST,and the additional
There's a space missing after "ILLEGAL REQUEST,".
> - * Called thru fc_lport_iterate().
> + * Called through fc_lport_iterate().
"thru" is perfectly valid and the author's choice.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2023-11-15 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 10:59 [PATCH] drivers: target: Fixed multiple typos in multiple files Muhammad Muzammil
2023-10-26 4:56 ` Muhammad Muzammil
2023-10-26 5:01 ` Randy Dunlap
2023-11-15 16:12 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17cmj10bl.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bostroesser@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.muzzammilashraf@gmail.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).