From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-scsi@vger.kernel.org, darren.kenny@oracle.com,
michael.christie@oracle.com, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com, d.bogdanov@yadro.com,
target-devel@vger.kernel.org
Subject: Re: [PATCH] scsi: target: core: Added a blank line after target_remove_from_tmr_list()
Date: Sat, 11 Feb 2023 15:34:35 +0530 [thread overview]
Message-ID: <b11240e7-e6d0-cb82-37f2-f0b69bcb069c@oracle.com> (raw)
In-Reply-To: <19b4a1e2-c8f8-dad1-51eb-c565fee405ee@oracle.com>
On 2/11/2023 1:50 PM, ALOK TIWARI wrote:
> commit "Fixes: 12b6fcd0ea7f" introduce that change in source code.
> that's reason we are using "fixes:". back-porting that change is
> creating awkward manual conflict resolution.
>
> Thanks,
> Alok
>
> On 2/11/2023 1:18 PM, Greg KH wrote:
>> On Fri, Feb 10, 2023 at 09:55:22AM -0800, Alok Tiwari wrote:
>>> There is no separate blank line between
>>> target_remove_from_tmr_list() and
>>> transport_cmd_check_stop_to_fabric
>>> As per coding-style, it is require to separate functions with one
>>> blank line.
>>>
>>> Fixes: 12b6fcd0ea7f ("scsi: target: core: Remove from tmr_list
>>> during LUN unlink")
>>> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
>>> ---
>>> drivers/target/target_core_transport.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/target/target_core_transport.c
>>> b/drivers/target/target_core_transport.c
>>> index 5926316252eb..f1cdf78fc5ef 100644
>>> --- a/drivers/target/target_core_transport.c
>>> +++ b/drivers/target/target_core_transport.c
>>> @@ -691,6 +691,7 @@ static void target_remove_from_tmr_list(struct
>>> se_cmd *cmd)
>>> spin_unlock_irqrestore(&dev->se_tmr_lock, flags);
>>> }
>>> }
>>> +
>>> /*
>>> * This function is called by the target core after the target
>>> core has
>>> * finished processing a SCSI command or SCSI TMF. Both the
>>> regular command
>>> --
>>> 2.39.1
>>>
>> Why is a coding style change tagged with a "fixes:" line and cc: stable?
>>
>> thanks,
>>
>> greg k-h
I will send new version to remove -> "fixes:" line and cc: stable
Thanks,
Alok
prev parent reply other threads:[~2023-02-11 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 17:55 [PATCH] scsi: target: core: Added a blank line after target_remove_from_tmr_list() Alok Tiwari
2023-02-11 7:48 ` Greg KH
2023-02-11 8:20 ` ALOK TIWARI
2023-02-11 10:04 ` ALOK TIWARI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b11240e7-e6d0-cb82-37f2-f0b69bcb069c@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=d.bogdanov@yadro.com \
--cc=darren.kenny@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).