From: Konstantin Shelekhin <k.shelekhin@yadro.com>
To: Bart Van Assche <bvanassche@acm.org>,
Anastasia Kovaleva <a.kovaleva@yadro.com>,
<martin.petersen@oracle.com>, <michael.christie@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org>,
<linux@yadro.com>
Subject: Re: [DMARC Error]Re: [RFC PATCH 2/3] target: core: apply the new wrapper to spc
Date: Wed, 26 Jul 2023 19:18:14 +0300 [thread overview]
Message-ID: <CUC8N20VEZVD.2FX0OUJJLSI68@pogg> (raw)
In-Reply-To: <f3a58522-3957-bd70-df87-9df7e4547195@acm.org>
On Wed Jul 26, 2023 at 6:15 PM MSK, Bart Van Assche wrote:
> «Внимание! Данное письмо от внешнего адресата!»
>
> On 7/26/23 04:55, Anastasia Kovaleva wrote:
> > +#define TARGET_PREFIX "core"
>
> I'm not sure this is a good choice for a logging prefix since this name
> does not make it clear that log lines come from the SCSI target core.
> How about "scsi_tgt" as prefix? "stgt" is probably not a good choice
> since this is the former name of a user-space SCSI target project
> (https://github.com/fujita/tgt).
>
> Bart.
I think scsit is a good choice, like nvmet we already have.
next prev parent reply other threads:[~2023-07-26 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 11:55 [RFC PATCH 0/3] SCSI target logs Anastasia Kovaleva
2023-07-26 11:55 ` [RFC PATCH 1/3] target: core: Initial work on improving " Anastasia Kovaleva
2023-07-26 11:55 ` [RFC PATCH 2/3] target: core: apply the new wrapper to spc Anastasia Kovaleva
2023-07-26 15:15 ` Bart Van Assche
2023-07-26 16:18 ` Konstantin Shelekhin [this message]
2023-07-26 11:55 ` [RFC PATCH 3/3] target: core: apply the new wrapper to iblock Anastasia Kovaleva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CUC8N20VEZVD.2FX0OUJJLSI68@pogg \
--to=k.shelekhin@yadro.com \
--cc=a.kovaleva@yadro.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).