From: Leon Romanovsky <leon@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: William Kucharski <william.kucharski@oracle.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] RDMA/srpt: Do not register event handler until srpt device is fully setup
Date: Sun, 4 Feb 2024 11:44:46 +0200 [thread overview]
Message-ID: <20240204094446.GA5400@unreal> (raw)
In-Reply-To: <894db19d-5287-4ed8-a0d9-0211b365eafa@acm.org>
On Thu, Feb 01, 2024 at 06:48:34AM -0800, Bart Van Assche wrote:
> On 1/30/24 22:24, William Kucharski wrote:
> > Upon rare occasions, KASAN reports a use-after-free Write
> > in srpt_refresh_port().
> >
> > This seems to be because an event handler is registered before the
> > srpt device is fully setup and a race condition upon error may leave a
> > partially setup event handler in place.
> >
> > Instead, only register the event handler after srpt device initialization
> > is complete.
>
> A Fixes: tag is missing. Otherwise this patch looks good to me. Hence:
I added this line:
Fixes: a42d985bd5b2 ("ib_srpt: Initial SRP Target merge for v3.3-rc1")
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Thanks
prev parent reply other threads:[~2024-02-04 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 6:24 [PATCH 0/1] RDMA/srpt: Do not register event handler until srpt device is fully setup William Kucharski
2024-01-31 6:24 ` [PATCH 1/1] " William Kucharski
2024-02-01 14:48 ` Bart Van Assche
2024-02-04 9:44 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240204094446.GA5400@unreal \
--to=leon@kernel.org \
--cc=bvanassche@acm.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).