From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: james.smart@broadcom.com, ram.vegesna@broadcom.com,
jejb@linux.ibm.com, rdunlap@infradead.org,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, coolrrsh@gmail.com
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v3] scsi: sli4: Remove code duplication
Date: Thu, 24 Aug 2023 21:12:52 -0400 [thread overview]
Message-ID: <169292577168.789945.14600068133090244401.b4-ty@oracle.com> (raw)
In-Reply-To: <20230817114301.17601-1-coolrrsh@gmail.com>
On Thu, 17 Aug 2023 17:13:01 +0530, coolrrsh@gmail.com wrote:
> In the function sli_xmit_bls_rsp64_wqe, the 'if' and 'else' conditions
> evaluates the same expression and gives same output. Also, params->s_id
> shall not be equal to U32_MAX. Therefore removing the unused code.
>
> This fixes coccinelle warning such as:
> drivers/scsi/elx/libefc_sli/sli4.c:2320:2-4: WARNING: possible
> condition with no effect (if == else)
>
> [...]
Applied to 6.6/scsi-queue, thanks!
[1/1] scsi: sli4: Remove code duplication
https://git.kernel.org/mkp/scsi/c/2d6f70fe175e
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2023-08-25 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 11:43 [PATCH v3] scsi: sli4: Remove code duplication coolrrsh
2023-08-17 17:24 ` Randy Dunlap
2023-08-21 20:59 ` Martin K. Petersen
2023-08-25 1:12 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169292577168.789945.14600068133090244401.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=coolrrsh@gmail.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ram.vegesna@broadcom.com \
--cc=rdunlap@infradead.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).