From: Denis Plotnikov <den-plotnikov@yandex-team.ru>
To: Varun Prakash <varun@chelsio.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: target: cxgbit: check skb dequeue result
Date: Mon, 10 Apr 2023 16:04:31 +0300 [thread overview]
Message-ID: <0b5cfdc4-817e-30b5-7295-5bca9c31a0b7@yandex-team.ru> (raw)
In-Reply-To: <BN9PR12MB532475CDE58B1E570B37DC60BC959@BN9PR12MB5324.namprd12.prod.outlook.com>
On 10.04.2023 14:45, Varun Prakash wrote:
>> On a couple of abort packet paths skb dequeuing may end up with
>> returning NULL, which, in turn, may end up with further null
>> pointer dereference.
>>
>> Fix it by checking the return value of skb dequeuing.
> skbs in csk->skbq are preallocated for critical events in cxgbit_alloc_csk_skb(),
> so there is no need to check for NULL.
Ok, thanks for the reply
prev parent reply other threads:[~2023-04-10 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 15:04 [PATCH] scsi: target: cxgbit: check skb dequeue result Denis Plotnikov
2023-04-07 19:16 ` Bodo Stroesser
2023-04-10 7:35 ` Denis Plotnikov
2023-04-10 11:45 ` Varun Prakash
2023-04-10 13:04 ` Denis Plotnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b5cfdc4-817e-30b5-7295-5bca9c31a0b7@yandex-team.ru \
--to=den-plotnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).