From: Andreas Hasenack <andreas@canonical.com>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: stgt@vger.kernel.org, sergio.durigan@canonical.com
Subject: Re: tgt on arm64 and USE_SIGNALFD
Date: Thu, 15 Feb 2024 10:39:43 -0300 [thread overview]
Message-ID: <CANYNYEHY=t+f7oV0A-+3faAgiSzb90mp6KB7XF2k=bVgpR_3dg@mail.gmail.com> (raw)
In-Reply-To: <20240215.092633.419504594582279426.fujita.tomonori@gmail.com>
Hello,
On Wed, Feb 14, 2024 at 9:26 PM FUJITA Tomonori
<fujita.tomonori@gmail.com> wrote:
>
> Hi,
>
> On Wed, 14 Feb 2024 17:14:42 -0300
> Andreas Hasenack <andreas@canonical.com> wrote:
>
> > is USE_SIGNALFD meant to be supported on arm64? The check in
> > bs/util.h[1] is looking for __NR_signalfd, but arm64 only has the
> > newer __NR_signalfd4[2]:
> >
> > #if defined(__NR_signalfd) && defined(USE_SIGNALFD)
> > ...
> > #else
> > #define __signalfd(fd, mask, flags) (-1)
> > struct signalfd_siginfo {
> > };
> > #endif
>
> I think that we don't need this hack anymore (it was necessary when
> the signalfd feature was introduced). I've not tested on arm64 but
> I guess that simply using sys/signalfd.h works like the following?
Yes, thank you, that worked just fine!
next prev parent reply other threads:[~2024-02-15 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 20:14 tgt on arm64 and USE_SIGNALFD Andreas Hasenack
2024-02-15 0:26 ` FUJITA Tomonori
2024-02-15 13:39 ` Andreas Hasenack [this message]
2024-02-16 10:01 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANYNYEHY=t+f7oV0A-+3faAgiSzb90mp6KB7XF2k=bVgpR_3dg@mail.gmail.com' \
--to=andreas@canonical.com \
--cc=fujita.tomonori@gmail.com \
--cc=sergio.durigan@canonical.com \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).