From: Lee Duncan <lduncan@suse.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: stgt@vger.kernel.org
Subject: Re: tgtadm delete without lld specified?
Date: Mon, 21 Apr 2014 09:44:54 -0700 [thread overview]
Message-ID: <53554B06.7070802@suse.com> (raw)
In-Reply-To: <20140420.212000.1305564732068189294.fujita.tomonori@lab.ntt.co.jp>
On 04/20/2014 05:20 AM, FUJITA Tomonori wrote:
> On Wed, 16 Apr 2014 16:40:09 -0700
> Lee Duncan <lduncan@suse.com> wrote:
>
>> I am debugging a problem on SUSE 11 SP3, with tgt 0.9.10.
>>
>> I am creating two iSCSI targets using targets.conf. Neither target
>> specifies a low-level driver, and there is no default-driver specified
>> either.
>>
>> The targets looks something like this:
>>
>> <target iqn....t1>
>> backing-store /dev/some-device
>> vendor_id someid
>> product_id volume-num1
>> </target>
>>
>> I create two of these targets, t1, and t2, then I using open-iscsi to
>> login to the first target, t1, then logout.
>>
>> Then I run "tgt-admin --delete "iqn...t1". As you know, this just runs
>> "tgtadm --op delete --mode target --tid=<tid-of-t1>". No low-level
>> driver is specified.
>>
>> Then I try to login to the second target, t2, using open-iscsi, and
>> the login hangs. This is because tgtd has died.
>>
>> Further analysis shows that tgtd dies because when it tries to look up
>> the iscsi target structure for t2, the t1 entry is still around. And
>> when the code tries to get the name of this no-longer-existing target,
>> it gets NULL and tries to compare that with the iqn name being
>> added. This makes strcmp() very unhappy.
>
> Surely, sounds a bug. The latest code still has this bug?
I will test the latest code, then submit a patch if the problem still
exists there.
>
>
>> I find that if I manually specify the lld either on the command line
>> of "tgtadm", or in one of the config files, then this problem goes
>> away.
>>
>> It looks like when I don't specify any LLD the upper-level code
>> defaults to low-lever-driver zero! This seems like a bug to me.
>>
>> Shouldn't the "tgtadm" command enforce specifying the low-level
>> driver?
>
> I guess that tgtadm command should use 'iscsi' by default if the
> low-level driver is not specified.
> --
> To unsubscribe from this list: send the line "unsubscribe stgt" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Lee Duncan
SUSE Labs
prev parent reply other threads:[~2014-04-21 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 23:40 tgtadm delete without lld specified? Lee Duncan
2014-04-20 12:20 ` FUJITA Tomonori
2014-04-21 16:44 ` Lee Duncan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53554B06.7070802@suse.com \
--to=lduncan@suse.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).