From: FUJITA Tomonori <tomof@acm.org>
To: apollon@skroutz.gr
Cc: stgt@vger.kernel.org, stsp@users.sourceforge.net,
ryan.harper@canonical.com, apoikos@debian.org
Subject: Re: [PATCH] Use ULLONG_MAX when checking for strtoull overflow
Date: Thu, 02 Jun 2016 11:11:15 +0900 (JST) [thread overview]
Message-ID: <20160602.111115.1898388363586166986.tomof@acm.org> (raw)
In-Reply-To: <1464081304-21761-1-git-send-email-apollon@skroutz.gr>
On Tue, 24 May 2016 12:15:04 +0300
Apollon Oikonomopoulos <apollon@skroutz.gr> wrote:
> From: Apollon Oikonomopoulos <apoikos@debian.org>
>
> According to strtoull(3):
>
> [...] Precisely the same holds for strtoull() (with ULLONG_MAX instead
> of ULONG_MAX).
>
> Since we are using strtoull(3) and not strtoul(3), the check should be
> made against ULLONG_MAX. Note that at least on amd64 ULONG_MAX and
> ULLONG_MAX are the same, but this is not guaranteed to be the case for
> other architectures as well.
>
> Signed-off-by: Apollon Oikonomopoulos <apoikos@debian.org>
> ---
> usr/util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
prev parent reply other threads:[~2016-06-02 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 9:15 [PATCH] Use ULLONG_MAX when checking for strtoull overflow Apollon Oikonomopoulos
2016-06-02 2:11 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602.111115.1898388363586166986.tomof@acm.org \
--to=tomof@acm.org \
--cc=apoikos@debian.org \
--cc=apollon@skroutz.gr \
--cc=ryan.harper@canonical.com \
--cc=stgt@vger.kernel.org \
--cc=stsp@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).