From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: borg@uu3.net
Cc: stgt@vger.kernel.org, yamada.hideki@lab.ntt.co.jp,
konishi.ryusuke@lab.ntt.co.jp
Subject: Re: Little bug in STGT
Date: Wed, 26 Nov 2014 13:51:05 +0900 (JST) [thread overview]
Message-ID: <20141126.135105.1568838937885770687.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <Pine.LNX.4.64.1411251809010.24756@cube>
Hi,
On Tue, 25 Nov 2014 18:13:27 +0100 (CET)
borg@uu3.net wrote:
> Sorry for writing directly, but this tiny typo is not
> worth the effort of subscribing.
> It prevents a deletion of entry from iqn_acl.
Thanks a lot! Applied.
You can post anything to the mailing list without subscribing.
> Regards,
> Borg
>
>
> diff --git a/usr/mgmt.c b/usr/mgmt.c
> index 1eae0c9..3587f4b 100644
> --- a/usr/mgmt.c
> +++ b/usr/mgmt.c
> @@ -152,7 +152,7 @@ static tgtadm_err target_mgmt(int lld_no, struct
> mgmt_task *
> mtask)
> p = strstr(mtask->req_buf, "initiator-name=");
> if (p) {
> p += strlen("initiator-name=");
> - adm_err = iqn_acl_del(req->tid, p + strlen("initiator-name="));
> + adm_err = iqn_acl_del(req->tid, p);
> if (adm_err != TGTADM_SUCCESS) {
> eprintf("Failed to unbind by name: %s\n", p);
> break;
>
parent reply other threads:[~2014-11-26 4:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <Pine.LNX.4.64.1411251809010.24756@cube>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126.135105.1568838937885770687.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=borg@uu3.net \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=stgt@vger.kernel.org \
--cc=yamada.hideki@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).