From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: phillip.brown.j@gmail.com
Cc: stgt@vger.kernel.org
Subject: Re: "tgtadm --mode system --show" doesn't show global 'outgoing' users if there are no global incoming users
Date: Fri, 22 Aug 2014 19:33:11 +0900 (JST) [thread overview]
Message-ID: <20140822.193311.1545942096518960826.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <20140822.192317.1898388363586166083.fujita.tomonori@lab.ntt.co.jp>
On Fri, 22 Aug 2014 19:23:17 +0900 (JST)
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> Hi,
>
> On Fri, 15 Aug 2014 16:39:18 +1000
> Phillip Brown <phillip.brown.j@gmail.com> wrote:
>
>> Problem seems to be with this 'if' statement in targets.c:system_show
>> function
>>
>> --------->> if (global_target.account.nr_inaccount) {
>> int i, aid;
>> concat_printf(b, _TAB1 "%s\n", "Account information:\n");
>> for (i = 0; i < global_target.account.nr_inaccount; i++) {
>> aid = global_target.account.in_aids[i];
>> concat_printf(b, _TAB1 "%s\n",
>> __account_lookup_id(aid)->user);
>> }
>> if (global_target.account.out_aid) {
>> aid = global_target.account.out_aid;
>> concat_printf(b, _TAB1 "%s (outgoing)\n",
>> __account_lookup_id(aid)->user);
>> }
>> }
>>
>> Does there really need to be that test?
>
> Probably, I wrote the above code but can't recall why. Looks like we
> can remove the above 'if'. Can you send a patch?
Now I recalled.
With one-way CHAP authentication, a target authenticate initiators
(in account). The opposite is not supported. So if an out account
always needs in account(s).
prev parent reply other threads:[~2014-08-22 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 6:39 "tgtadm --mode system --show" doesn't show global 'outgoing' users if there are no global incoming users Phillip Brown
2014-08-22 10:23 ` FUJITA Tomonori
2014-08-22 10:33 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822.193311.1545942096518960826.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=phillip.brown.j@gmail.com \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).