From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: ronniesahlberg@gmail.com
Cc: stgt@vger.kernel.org
Subject: Re: [PATCH] MMC: add a dedicated backend for MMC so that supported-opcode map works
Date: Fri, 22 Aug 2014 19:16:17 +0900 (JST) [thread overview]
Message-ID: <20140822.191617.1568838937885767760.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <1408578338-9262-2-git-send-email-ronniesahlberg@gmail.com>
On Wed, 20 Aug 2014 16:45:38 -0700
Ronnie Sahlberg <ronniesahlberg@gmail.com> wrote:
> MMC has been broken for a while since some of the vital opcodes
> (GET_CONFIGURATION) and friends are not in the supported opcode
> whitelist in bs_rdwr.c.
> The real problem is that we have a bs_rdwr.c backend for SBC and we
> piggyback on this SBC backend also for the MMC emulation.
>
> Add defines for the missing MMC opcodes and create a new backend
> dedicated for MMC that has the proper whitelist for MMC opcodes.
> This new backend is actually part of bs_rdwr.c and shares all the
> code with the SBC based backend.
> However the new MMC backend will have a different name "mmc" to indicate
> it is for the MMC emulation and it comes with a supported opcode
> whitelist that is appropriate for MMC devices.
>
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
> usr/bs_rdwr.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++----
> usr/mmc.c | 6 +++---
> usr/scsi.h | 9 +++++++++
> 3 files changed, 62 insertions(+), 7 deletions(-)
Applied, thanks!
prev parent reply other threads:[~2014-08-22 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 23:45 [PATCH] Fix for MMC so it works again Ronnie Sahlberg
2014-08-20 23:45 ` [PATCH] MMC: add a dedicated backend for MMC so that supported-opcode map works Ronnie Sahlberg
2014-08-22 10:16 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822.191617.1568838937885767760.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=ronniesahlberg@gmail.com \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).