From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: konishi.ryusuke@lab.ntt.co.jp
Cc: stgt@vger.kernel.org
Subject: Re: [PATCH] tgtd: fix leak of task_in_scsi flag
Date: Mon, 17 Mar 2014 14:48:32 +0900 (JST) [thread overview]
Message-ID: <20140317.144832.1568838937885780027.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <1395027541-11479-1-git-send-email-konishi.ryusuke@lab.ntt.co.jp>
On Mon, 17 Mar 2014 12:39:01 +0900
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> wrote:
> When target_mgmt_request() function receives unknown or unsupported
> task management function code or task was already completed for
> ABORT_TASK request, iscsi_tm_execute() and iser_tm_exec() functions
> exit without clearing task_in_scsi flag even though scsi command is
> not in processing.
>
> This is because the current implementation of target_mgmt_request()
> function returns -EINVAL or -EEXIST for the above cases and
> iscsi_tm_execute() and iser_tm_exec() do not handle these return
> codes.
>
> This fixes the issue by changing the return value of
> target_mgmt_request() to MGMT_REQ_FAILED for such cases.
>
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> ---
> usr/target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
prev parent reply other threads:[~2014-03-17 5:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 3:39 [PATCH] tgtd: fix leak of task_in_scsi flag Ryusuke Konishi
2014-03-17 5:48 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317.144832.1568838937885780027.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).