From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: dlambrig@redhat.com
Cc: stgt@vger.kernel.org
Subject: Re: [PATCH] Add support for gluster backing store
Date: Fri, 14 Mar 2014 05:44:33 +0900 (JST) [thread overview]
Message-ID: <20140314.054433.1568838937885771579.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <1394636124-8660-1-git-send-email-dlambrig@redhat.com>
On Wed, 12 Mar 2014 10:55:24 -0400
Dan Lambright <dlambrig@redhat.com> wrote:
> Gluster is a distributed file system (www.gluster.org). The
> backing store gives block access protocols such as iSCSI
> access to data within gluster.
>
> Gluster data resides on volumes which are physically located
> on servers. A "LUN" is represented by a file within
> a volume. To specify which file to use:
>
> --bstype=glfs
> --backing-store="volume@hostname:filename"
>
> Optionally, logs may be specified. See README.glfs
>
> All I/Os are synchronous. This is based off the rdrw and
> rbd backend storage drivers.
>
> Signed-off-by: Dan Lambright <dlambrig@redhat.com>
> ---
> Makefile | 1 +
> doc/README.glfs | 50 +++++
> usr/Makefile | 7 +
> usr/bs_glfs.c | 561 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Thanks! Can you fix the following some style errors?
fujita@rose:~/git/tgt$ ./scripts/checkpatch.pl
~/0001-Add-support-for-gluster-backing-store.patch
WARNING: quoted string split across lines
#370: FILE: usr/bs_glfs.c:239:
+ eprintf("Failed to punch hole for "
+ "WRITE_SAME
command\n");
WARNING: quoted string split across lines
#481: FILE: usr/bs_glfs.c:350:
+ eprintf("Failed to punch hole for"
+ "
UNMAP at offset:%" PRIu64
WARNING: line over 80 characters
#557: FILE: usr/bs_glfs.c:426:
+ ret = glfs_set_volfile_server(fs, "tcp", servername,
GLUSTER_PORT);
ERROR: code indent should use tabs where possible
#615: FILE: usr/bs_glfs.c:484:
+ /* Jump past the semicolon, if we stopped at one */$
ERROR: code indent should use tabs where possible
#616: FILE: usr/bs_glfs.c:485:
+ if (**p == ';')$
WARNING: please, no spaces at the start of a line
#616: FILE: usr/bs_glfs.c:485:
+ if (**p == ';')$
ERROR: code indent should use tabs where possible
#617: FILE: usr/bs_glfs.c:486:
+ *p = end + 1;$
WARNING: please, no spaces at the start of a line
#617: FILE: usr/bs_glfs.c:486:
+ *p = end + 1;$
total: 3 errors, 5 warnings, 637 lines checked
NOTE: whitespace errors detected, you may wish to use
scripts/cleanpatch or
scripts/cleanfile
/home/fujita/0001-Add-support-for-gluster-backing-store.patch has
style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
prev parent reply other threads:[~2014-03-13 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 14:55 [PATCH] Add support for gluster backing store Dan Lambright
2014-03-13 20:44 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314.054433.1568838937885771579.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=dlambrig@redhat.com \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).