From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: ronniesahlberg@gmail.com
Cc: stgt@vger.kernel.org
Subject: Re: [PATCH] The first byte in CDB USAGE DATA should be the opcode number and not 0xFF
Date: Wed, 26 Feb 2014 20:23:18 +0900 (JST) [thread overview]
Message-ID: <20140226.202318.1568838937885768236.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <1393298109-16052-2-git-send-email-ronniesahlberg@gmail.com>
On Mon, 24 Feb 2014 19:15:09 -0800
Ronnie Sahlberg <ronniesahlberg@gmail.com> wrote:
> When we build the CDB USAGE DATA field for a REPORT SUPPORTED OPCODES reply
> we must set the first byte of the field to the opcode itself, and not
> to 0xFF as we currently do.
>
> SPC4:
> ...
> The CDB USAGE DATA field contains information about the CDB for the command being queried.
> The first byte of the CDB USAGE FIELD field shall contain the operation code for the command being queried.
> ...
>
> A test for this is available in the libiscsi test utility :
>
> ./bin/iscsi-test-cu iscsi://127.0.0.1/iqn.ronnie.test/1 --test=SCSI.ReportSupportedOpcodes.OneCommand
>
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
> usr/scsi.c | 195 ++++++++++++++++++++++++++++++++++++------------------------
> 1 files changed, 118 insertions(+), 77 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2014-02-26 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 3:15 [PATCH] Fix ReportSupportedOpcode command to set the opcode Ronnie Sahlberg
2014-02-25 3:15 ` [PATCH] The first byte in CDB USAGE DATA should be the opcode number and not 0xFF Ronnie Sahlberg
2014-02-26 11:23 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226.202318.1568838937885768236.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=ronniesahlberg@gmail.com \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).