From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: konishi.ryusuke@lab.ntt.co.jp
Cc: stgt@vger.kernel.org
Subject: Re: [PATCH] iscsi: fix leak of session->initiator_alias
Date: Sun, 23 Feb 2014 21:55:12 +0900 [thread overview]
Message-ID: <20140223215255T.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <1392988502-8734-1-git-send-email-konishi.ryusuke@lab.ntt.co.jp>
On Fri, 21 Feb 2014 22:15:02 +0900
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> wrote:
> session->initiator_alias is not freed in error paths of
> session_create() and even in the normal path of session_destroy().
>
> This fixes these leak bugs.
>
> Note that we don't have to do a null check for
> session->initiator_alias before calling free(session->initiator_alias)
> because free() function simply ignores NULL pointer.
>
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> ---
> usr/iscsi/session.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks a lot!
prev parent reply other threads:[~2014-02-23 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 13:15 [PATCH] iscsi: fix leak of session->initiator_alias Ryusuke Konishi
2014-02-23 12:55 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140223215255T.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).