From: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
To: stgt@vger.kernel.org
Cc: sheepdog@lists.wpkg.org,
Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>,
Teruaki Ishizaki <ishizaki.teruaki@lab.ntt.co.jp>
Subject: [PATCH 4/4] sheepdog: handle a case of snapshot -> failover
Date: Mon, 20 Jul 2015 15:59:15 +0900 [thread overview]
Message-ID: <1437375555-11698-4-git-send-email-mitake.hitoshi@lab.ntt.co.jp> (raw)
In-Reply-To: <1437375555-11698-1-git-send-email-mitake.hitoshi@lab.ntt.co.jp>
If refreshed inode is snapshot, we can reload entire inode and switch
to working VDI immediately. It is required by the new refreshing
condition introduced in the commit 8f781f02ab of sheepdog.
Cc: Teruaki Ishizaki <ishizaki.teruaki@lab.ntt.co.jp>
Signed-off-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
---
usr/bs_sheepdog.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/usr/bs_sheepdog.c b/usr/bs_sheepdog.c
index 56630ac..99519ef 100644
--- a/usr/bs_sheepdog.c
+++ b/usr/bs_sheepdog.c
@@ -704,6 +704,34 @@ static int reload_inode(struct sheepdog_access_info *ai, int is_snapshot)
ret = -1;
goto ret;
}
+
+ if (!!ai->inode.snap_ctime) {
+ /*
+ * This is a case like below:
+ * take snapshot -> write something -> failover
+ *
+ * Because invalidated inode is readonly and latest
+ * working VDI can have COWed objects, we need to
+ * resolve VID and reload its entire inode object.
+ */
+ memset(tag, 0, sizeof(tag));
+
+ ret = find_vdi_name(ai, ai->inode.name, CURRENT_VDI_ID,
+ tag, &vid, 1);
+ if (ret) {
+ ret = -1;
+ goto ret;
+ }
+
+ ret = read_object(ai, (char *)&ai->inode,
+ vid_to_vdi_oid(vid),
+ ai->inode.nr_copies, SD_INODE_SIZE, 0,
+ &need_reload);
+ if (ret) {
+ ret = -1;
+ goto ret;
+ }
+ }
}
ai->min_dirty_data_idx = UINT32_MAX;
--
1.9.1
prev parent reply other threads:[~2015-07-20 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 6:59 [PATCH 1/4] sheepdog: prevent double locking during inode reload Hitoshi Mitake
2015-07-20 6:59 ` [PATCH 2/4] sheepdog: serialize overwrapping request Hitoshi Mitake
2015-07-20 6:59 ` [PATCH 3/4] sheepdog: pass a correct flag to find_vdi_name() Hitoshi Mitake
2015-07-20 6:59 ` Hitoshi Mitake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437375555-11698-4-git-send-email-mitake.hitoshi@lab.ntt.co.jp \
--to=mitake.hitoshi@lab.ntt.co.jp \
--cc=ishizaki.teruaki@lab.ntt.co.jp \
--cc=sheepdog@lists.wpkg.org \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).