stgt.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roi Dayan <roid@mellanox.com>
To: fujita.tomonori@lab.ntt.co.jp
Cc: stgt@vger.kernel.org, Roi Dayan <roid@mellanox.com>
Subject: [PATCH] iser: fix local conn params being reset to default
Date: Tue, 28 Oct 2014 17:41:06 +0200	[thread overview]
Message-ID: <1414510866-14770-1-git-send-email-roid@mellanox.com> (raw)

Instead of reseting the params to default if they pass it
we should reset to max if they pass it.

Signed-off-by: Roi Dayan <roid@mellanox.com>
---
 usr/iscsi/iser_text.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/usr/iscsi/iser_text.c b/usr/iscsi/iser_text.c
index 8180dbc..b8c5136 100644
--- a/usr/iscsi/iser_text.c
+++ b/usr/iscsi/iser_text.c
@@ -342,8 +342,8 @@ static int iser_login_check_params(struct iscsi_connection *iscsi_conn,
 		if (p[i].state == KEY_STATE_START && p[i].val != session_keys[i].def) {
 			if (iscsi_conn->state == STATE_LOGIN) {
 				if (i >= ISCSI_PARAM_FIRST_LOCAL) {
-					if (p[i].val > session_keys[i].def)
-						p[i].val = session_keys[i].def;
+					if (p[i].val > session_keys[i].max)
+						p[i].val = session_keys[i].max;
 					p[i].state = KEY_STATE_DONE;
 					continue;
 				}
-- 
1.8.4.3

             reply	other threads:[~2014-10-28 15:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 15:41 Roi Dayan [this message]
2014-10-28 21:58 ` [PATCH] iser: fix local conn params being reset to default FUJITA Tomonori
2014-10-29  5:51 ` Or Gerlitz
2014-10-29  6:36   ` Roi Dayan
2014-10-29  7:49   ` Roi Dayan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414510866-14770-1-git-send-email-roid@mellanox.com \
    --to=roid@mellanox.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=stgt@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).