Stable Archive mirror
 help / color / mirror / Atom feed

From: Ahmed Zaki <ahmed.zaki@intel.com>
To: <stable@vger.kernel.org>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
	"Chittim, Madhu" <madhu.chittim@intel.com>,
	"Samudrala, Sridhar" <sridhar.samudrala@intel.com>
Subject: Fix Intel's ice driver in stable
Date: Wed, 15 May 2024 15:16:39 -0600	[thread overview]
Message-ID: <b0d2b0b3-bbd5-4091-abf8-dfb6c5a57cf4@intel.com> (raw)

Hello,

Upstream commit 11fbb1bfb5bc8c98b2d7db9da332b5e568f4aaab ("ice: use 
relative VSI index for VFs VSIs") was applied to stable 6.1, 6.6 and 6.8:

6.1: 5693dd6d3d01f0eea24401f815c98b64cb315b67
6.6: c926393dc3442c38fdcab17d040837cf4acad1c3
6.8: d3da0d4d9fb472ad7dccb784f3d9de40d0c2f6a9

However, it was a part of a series submitted to net-next [1]. Applying 
this one patch on its own broke the VF devices created with the ice as a PF:

   # [  307.688237] iavf: Intel(R) Ethernet Adaptive Virtual Function 
Network Driver
   # [  307.688241] Copyright (c) 2013 - 2018 Intel Corporation.
   # [  307.688424] iavf 0000:af:01.0: enabling device (0000 -> 0002)
   # [  307.758860] iavf 0000:af:01.0: Invalid MAC address 
00:00:00:00:00:00, using random
   # [  307.759628] iavf 0000:af:01.0: Multiqueue Enabled: Queue pair 
count = 16
   # [  307.759683] iavf 0000:af:01.0: MAC address: 6a:46:83:88:c2:26
   # [  307.759688] iavf 0000:af:01.0: GRO is enabled
   # [  307.790937] iavf 0000:af:01.0 ens802f0v0: renamed from eth0
   # [  307.896041] iavf 0000:af:01.0: PF returned error -5 
(IAVF_ERR_PARAM) to our request 6
   # [  307.916967] iavf 0000:af:01.0: PF returned error -5 
(IAVF_ERR_PARAM) to our request 8


The VF initialization fails and the VF device is completely unusable.

This can be fixed either by:
1 - Reverting the above mentioned commit (upstream 
11fbb1bfb5bc8c98b2d7db9da332b5e568f4aaab)

Or,

2 - applying the following upstream commits (part of the series):
  a) a21605993dd5dfd15edfa7f06705ede17b519026 ("ice: pass VSI pointer 
into ice_vc_isvalid_q_id")
  b) 363f689600dd010703ce6391bcfc729a97d21840 ("ice: remove unnecessary 
duplicate checks for VF VSI ID")


Thanks,
Ahmed

[1]: https://www.spinics.net/lists/netdev/msg979289.html

next             reply	other threads:[~2024-05-15 21:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15 21:16 Ahmed Zaki [this message]
2024-05-16  5:12 ` Fix Intel's ice driver in stable Samudrala, Sridhar
2024-05-16  5:46   ` Greg KH
2024-05-16 17:08     ` Jacob Keller
2024-05-16  6:44 ` Greg KH
2024-05-16 17:10   ` Jacob Keller
2024-05-22 15:44     ` Greg KH
2024-05-22 20:28       ` Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0d2b0b3-bbd5-4091-abf8-dfb6c5a57cf4@intel.com \
    --to=ahmed.zaki@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=jacob.e.keller@intel.com \
    --cc=madhu.chittim@intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).