From: David Lechner <dlechner@baylibre.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Mark Brown" <broonie@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
stable@vger.kernel.org, stable-commits@vger.kernel.org,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>
Subject: Re: Patch "spi: axi-spi-engine: Convert to platform remove callback returning void" has been added to the 6.1-stable tree
Date: Mon, 13 May 2024 09:44:08 -0500 [thread overview]
Message-ID: <CAMknhBHwxd6ThV_ddkBNsJ5F8gmDEfx21g6JSnhnatCB_siHzw@mail.gmail.com> (raw)
In-Reply-To: <2024051310-spindle-resort-1219@gregkh>
On Mon, May 13, 2024 at 8:07 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, May 07, 2024 at 11:39:58PM +0900, Mark Brown wrote:
> > On Tue, May 07, 2024 at 09:22:48AM -0500, David Lechner wrote:
> >
> > > It's just fixing a theoretical problem, not one that has actually
> > > caused problems for people. The stable guidelines I read [1] said we
> > > shouldn't include fixes like that.
> >
> > > [1]: https://docs.kernel.org/process/stable-kernel-rules.html
> >
> > > So, sure it would probably be harmless to include it without the
> > > other dependencies. But not sure it is worth the effort for only
> > > a theoretical problem.
> >
> > The written stable guidelines don't really reflect what's going on with
> > stable these days at all, these days it's very aggressive with what it
> > backports.
>
> It's "aggressive" in that many dependent patches are finally being
> properly found and backported as needed to be able to get the "real" fix
> applied properly. That's all, nothing odd here, and all of these
> commits have been through proper review and development and acceptance
> already, so it's not like they are brand new things, they are required
> for real fixes.
>
> > Personally I tend to be a lot more conservative than this
> > and would tend to agree that this isn't a great candidate for
> > backporting but people seem OK with this sort of stuff.
>
> Again, we want to keep as close as possible with Linus's tree because
> ALMOST EVERY time we try to do our own thing, we get something wrong.
> Keeping in sync is essencial to rely on our overall testing and future
> fix ability to keep in sync properly.
>
> To attempt to do "one off" backports all over the place just does not
> work, we have tried it and failed. To not accept the fix at all leaves
> us vulnerable to a known bug, why would that be ok?
>
> Change is good, and these changes are extra-good as they fix things.
>
I see there are differences in opinion of what a "real" problem is.
And it sounds like the opinions have been shifting while I was away
from kernel development for a few years.
If you prefer to take this patch and all of it's dependencies to keep
things as close to mainline as possible, I guess that is fine.
prev parent reply other threads:[~2024-05-13 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240506193007.271745-1-sashal@kernel.org>
2024-05-06 20:43 ` Patch "spi: axi-spi-engine: Convert to platform remove callback returning void" has been added to the 6.1-stable tree David Lechner
2024-05-07 6:13 ` Uwe Kleine-König
2024-05-07 13:59 ` David Lechner
2024-05-07 14:08 ` Uwe Kleine-König
2024-05-07 14:22 ` David Lechner
2024-05-07 14:39 ` Mark Brown
2024-05-13 13:07 ` Greg KH
2024-05-13 14:44 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMknhBHwxd6ThV_ddkBNsJ5F8gmDEfx21g6JSnhnatCB_siHzw@mail.gmail.com \
--to=dlechner@baylibre.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).