From: Inki Dae <daeinki@gmail.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/exynos: hdmi: report safe 640x480 mode as a fallback when no EDID found
Date: Tue, 14 May 2024 15:27:18 +0900 [thread overview]
Message-ID: <CAAQKjZMwAJrKfccC+2cB8pqGrdrgBToSkvEa0BRnfU+CO9n2Cg@mail.gmail.com> (raw)
In-Reply-To: <20240425094851.994055-1-m.szyprowski@samsung.com>
Hi Marek,
2024년 4월 25일 (목) 오후 6:49, Marek Szyprowski <m.szyprowski@samsung.com>님이 작성:
>
> When reading EDID fails and driver reports no modes available, the DRM
> core adds an artificial 1024x786 mode to the connector. Unfortunately
> some variants of the Exynos HDMI (like the one in Exynos4 SoCs) are not
> able to drive such mode, so report a safe 640x480 mode instead of nothing
> in case of the EDID reading failure.
>
> This fixes the following issue observed on Trats2 board since commit
> 13d5b040363c ("drm/exynos: do not return negative values from .get_modes()"):
Applied.
Thanks,
Inki Dae
>
> [drm] Exynos DRM: using 11c00000.fimd device for DMA mapping operations
> exynos-drm exynos-drm: bound 11c00000.fimd (ops fimd_component_ops)
> exynos-drm exynos-drm: bound 12c10000.mixer (ops mixer_component_ops)
> exynos-dsi 11c80000.dsi: [drm:samsung_dsim_host_attach] Attached s6e8aa0 device (lanes:4 bpp:24 mode-flags:0x10b)
> exynos-drm exynos-drm: bound 11c80000.dsi (ops exynos_dsi_component_ops)
> exynos-drm exynos-drm: bound 12d00000.hdmi (ops hdmi_component_ops)
> [drm] Initialized exynos 1.1.0 20180330 for exynos-drm on minor 1
> exynos-hdmi 12d00000.hdmi: [drm:hdmiphy_enable.part.0] *ERROR* PLL could not reach steady state
> panel-samsung-s6e8aa0 11c80000.dsi.0: ID: 0xa2, 0x20, 0x8c
> exynos-mixer 12c10000.mixer: timeout waiting for VSYNC
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 11 at drivers/gpu/drm/drm_atomic_helper.c:1682 drm_atomic_helper_wait_for_vblanks.part.0+0x2b0/0x2b8
> [CRTC:70:crtc-1] vblank wait timed out
> Modules linked in:
> CPU: 1 PID: 11 Comm: kworker/u16:0 Not tainted 6.9.0-rc5-next-20240424 #14913
> Hardware name: Samsung Exynos (Flattened Device Tree)
> Workqueue: events_unbound deferred_probe_work_func
> Call trace:
> unwind_backtrace from show_stack+0x10/0x14
> show_stack from dump_stack_lvl+0x68/0x88
> dump_stack_lvl from __warn+0x7c/0x1c4
> __warn from warn_slowpath_fmt+0x11c/0x1a8
> warn_slowpath_fmt from drm_atomic_helper_wait_for_vblanks.part.0+0x2b0/0x2b8
> drm_atomic_helper_wait_for_vblanks.part.0 from drm_atomic_helper_commit_tail_rpm+0x7c/0x8c
> drm_atomic_helper_commit_tail_rpm from commit_tail+0x9c/0x184
> commit_tail from drm_atomic_helper_commit+0x168/0x190
> drm_atomic_helper_commit from drm_atomic_commit+0xb4/0xe0
> drm_atomic_commit from drm_client_modeset_commit_atomic+0x23c/0x27c
> drm_client_modeset_commit_atomic from drm_client_modeset_commit_locked+0x60/0x1cc
> drm_client_modeset_commit_locked from drm_client_modeset_commit+0x24/0x40
> drm_client_modeset_commit from __drm_fb_helper_restore_fbdev_mode_unlocked+0x9c/0xc4
> __drm_fb_helper_restore_fbdev_mode_unlocked from drm_fb_helper_set_par+0x2c/0x3c
> drm_fb_helper_set_par from fbcon_init+0x3d8/0x550
> fbcon_init from visual_init+0xc0/0x108
> visual_init from do_bind_con_driver+0x1b8/0x3a4
> do_bind_con_driver from do_take_over_console+0x140/0x1ec
> do_take_over_console from do_fbcon_takeover+0x70/0xd0
> do_fbcon_takeover from fbcon_fb_registered+0x19c/0x1ac
> fbcon_fb_registered from register_framebuffer+0x190/0x21c
> register_framebuffer from __drm_fb_helper_initial_config_and_unlock+0x350/0x574
> __drm_fb_helper_initial_config_and_unlock from exynos_drm_fbdev_client_hotplug+0x6c/0xb0
> exynos_drm_fbdev_client_hotplug from drm_client_register+0x58/0x94
> drm_client_register from exynos_drm_bind+0x160/0x190
> exynos_drm_bind from try_to_bring_up_aggregate_device+0x200/0x2d8
> try_to_bring_up_aggregate_device from __component_add+0xb0/0x170
> __component_add from mixer_probe+0x74/0xcc
> mixer_probe from platform_probe+0x5c/0xb8
> platform_probe from really_probe+0xe0/0x3d8
> really_probe from __driver_probe_device+0x9c/0x1e4
> __driver_probe_device from driver_probe_device+0x30/0xc0
> driver_probe_device from __device_attach_driver+0xa8/0x120
> __device_attach_driver from bus_for_each_drv+0x80/0xcc
> bus_for_each_drv from __device_attach+0xac/0x1fc
> __device_attach from bus_probe_device+0x8c/0x90
> bus_probe_device from deferred_probe_work_func+0x98/0xe0
> deferred_probe_work_func from process_one_work+0x240/0x6d0
> process_one_work from worker_thread+0x1a0/0x3f4
> worker_thread from kthread+0x104/0x138
> kthread from ret_from_fork+0x14/0x28
> Exception stack(0xf0895fb0 to 0xf0895ff8)
> ...
> irq event stamp: 82357
> hardirqs last enabled at (82363): [<c01a96e8>] vprintk_emit+0x308/0x33c
> hardirqs last disabled at (82368): [<c01a969c>] vprintk_emit+0x2bc/0x33c
> softirqs last enabled at (81614): [<c0101644>] __do_softirq+0x320/0x500
> softirqs last disabled at (81609): [<c012dfe0>] __irq_exit_rcu+0x130/0x184
> ---[ end trace 0000000000000000 ]---
> exynos-drm exynos-drm: [drm] *ERROR* flip_done timed out
> exynos-drm exynos-drm: [drm] *ERROR* [CRTC:70:crtc-1] commit wait timed out
> exynos-drm exynos-drm: [drm] *ERROR* flip_done timed out
> exynos-drm exynos-drm: [drm] *ERROR* [CONNECTOR:74:HDMI-A-1] commit wait timed out
> exynos-drm exynos-drm: [drm] *ERROR* flip_done timed out
> exynos-drm exynos-drm: [drm] *ERROR* [PLANE:56:plane-5] commit wait timed out
> exynos-mixer 12c10000.mixer: timeout waiting for VSYNC
>
> Cc: stable@vger.kernel.org
> Fixes: 13d5b040363c ("drm/exynos: do not return negative values from .get_modes()")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 5fdeec8a3875..9d246db6ef2b 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -887,11 +887,11 @@ static int hdmi_get_modes(struct drm_connector *connector)
> int ret;
>
> if (!hdata->ddc_adpt)
> - return 0;
> + goto no_edid;
>
> edid = drm_get_edid(connector, hdata->ddc_adpt);
> if (!edid)
> - return 0;
> + goto no_edid;
>
> hdata->dvi_mode = !connector->display_info.is_hdmi;
> DRM_DEV_DEBUG_KMS(hdata->dev, "%s : width[%d] x height[%d]\n",
> @@ -906,6 +906,9 @@ static int hdmi_get_modes(struct drm_connector *connector)
> kfree(edid);
>
> return ret;
> +
> +no_edid:
> + return drm_add_modes_noedid(connector, 640, 480);
> }
>
> static int hdmi_find_phy_conf(struct hdmi_context *hdata, u32 pixel_clock)
> --
> 2.34.1
>
>
prev parent reply other threads:[~2024-05-14 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240425094907eucas1p10a82102ccb08868dda93d6860b9177ec@eucas1p1.samsung.com>
2024-04-25 9:48 ` [PATCH] drm/exynos: hdmi: report safe 640x480 mode as a fallback when no EDID found Marek Szyprowski
2024-05-14 6:27 ` Inki Dae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAQKjZMwAJrKfccC+2cB8pqGrdrgBToSkvEa0BRnfU+CO9n2Cg@mail.gmail.com \
--to=daeinki@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=stable@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).