From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
"Lin, Wayne" <Wayne.Lin@amd.com>,
Linux regressions mailing list <regressions@lists.linux.dev>,
"Wentland, Harry" <Harry.Wentland@amd.com>
Cc: "lyude@redhat.com" <lyude@redhat.com>,
"imre.deak@intel.com" <imre.deak@intel.com>,
"Leon Weiß" <leon.weiss@ruhr-uni-bochum.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
Date: Sun, 12 May 2024 11:11:27 -0500 [thread overview]
Message-ID: <6f66e479-2f5a-477a-9705-dca4a3606760@amd.com> (raw)
In-Reply-To: <87wmo2hver.fsf@intel.com>
On 5/10/2024 4:24 AM, Jani Nikula wrote:
> On Fri, 10 May 2024, "Lin, Wayne" <Wayne.Lin@amd.com> wrote:
>> [Public]
>>
>>> -----Original Message-----
>>> From: Limonciello, Mario <Mario.Limonciello@amd.com>
>>> Sent: Friday, May 10, 2024 3:18 AM
>>> To: Linux regressions mailing list <regressions@lists.linux.dev>; Wentland, Harry
>>> <Harry.Wentland@amd.com>; Lin, Wayne <Wayne.Lin@amd.com>
>>> Cc: lyude@redhat.com; imre.deak@intel.com; Leon Weiß <leon.weiss@ruhr-uni-
>>> bochum.de>; stable@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-
>>> gfx@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
>>> Subject: Re: [PATCH] drm/mst: Fix NULL pointer dereference at
>>> drm_dp_add_payload_part2
>>>
>>> On 5/9/2024 07:43, Linux regression tracking (Thorsten Leemhuis) wrote:
>>>> On 18.04.24 21:43, Harry Wentland wrote:
>>>>> On 2024-03-07 01:29, Wayne Lin wrote:
>>>>>> [Why]
>>>>>> Commit:
>>>>>> - commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload
>>>>>> allocation/removement") accidently overwrite the commit
>>>>>> - commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in
>>>>>> drm_dp_add_payload_part2") which cause regression.
>>>>>>
>>>>>> [How]
>>>>>> Recover the original NULL fix and remove the unnecessary input
>>>>>> parameter 'state' for drm_dp_add_payload_part2().
>>>>>>
>>>>>> Fixes: 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload
>>>>>> allocation/removement")
>>>>>> Reported-by: Leon Weiß <leon.weiss@ruhr-uni-bochum.de>
>>>>>> Link:
>>>>>> https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.c
>>>>>> amel@ruhr-uni-bochum.de/
>>>>>> Cc: lyude@redhat.com
>>>>>> Cc: imre.deak@intel.com
>>>>>> Cc: stable@vger.kernel.org
>>>>>> Cc: regressions@lists.linux.dev
>>>>>> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
>>>>>
>>>>> I haven't been deep in MST code in a while but this all looks pretty
>>>>> straightforward and good.
>>>>>
>>>>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>>>>
>>>> Hmmm, that was three weeks ago, but it seems since then nothing
>>>> happened to fix the linked regression through this or some other
>>>> patch. Is there a reason? The build failure report from the CI maybe?
>>>
>>> It touches files outside of amd but only has an ack from AMD. I think we
>>> /probably/ want an ack from i915 and nouveau to take it through.
>>
>> Thanks, Mario!
>>
>> Hi Thorsten,
>> Yeah, like what Mario said. Would also like to have ack from i915 and nouveau.
>
> It usually works better if you Cc the folks you want an ack from! ;)
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
Thanks! Can someone with commit permissions take this to drm-misc?
next prev parent reply other threads:[~2024-05-12 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 6:29 [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 Wayne Lin
2024-04-15 2:55 ` Lin, Wayne
2024-04-18 19:43 ` Harry Wentland
2024-05-09 12:43 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-09 19:18 ` Mario Limonciello
2024-05-10 3:18 ` Lin, Wayne
2024-05-10 9:24 ` Jani Nikula
2024-05-12 16:11 ` Limonciello, Mario [this message]
2024-05-21 11:20 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-21 16:12 ` Alex Deucher
2024-05-21 17:39 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f66e479-2f5a-477a-9705-dca4a3606760@amd.com \
--to=mario.limonciello@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=leon.weiss@ruhr-uni-bochum.de \
--cc=lyude@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).