From: Valentin Obst <kernel@valentinobst.de>
To: mhiramat@kernel.org
Cc: a.hindborg@samsung.com, bp@alien8.de,
dave.hansen@linux.intel.com, gregkh@linuxfoundation.org,
hpa@zytor.com, john.m.baublitz@gmail.com, kernel@valentinobst.de,
linux-kernel@vger.kernel.org, mingo@kernel.org, mingo@redhat.com,
ojeda@kernel.org, peterz@infradead.org, sergio.collado@gmail.com,
stable@vger.kernel.org, tglx@linutronix.de, x86@kernel.org
Subject: Re: [PATCH v3] x86/tools: fix line number reported for malformed lines
Date: Wed, 15 May 2024 20:17:16 +0200 [thread overview]
Message-ID: <20240515181716.3313-1-kernel@valentinobst.de> (raw)
In-Reply-To: <20240403091748.ee180a7a1d4bf92e0c46fb8a@kernel.org>
> > Commit 35039eb6b199 ("x86: Show symbol name if insn decoder test failed")
> > included symbol lines in the post-processed objdump output consumed by
> > the insn decoder test. This broke the `instuction lines == total lines`
> > property that `insn_decoder_test.c` relied upon to print the offending
> > line's number in error messages. This has the consequence that the line
> > number reported on a test failure is unreated to, and much smaller than,
> > the line that actually caused the problem.
> >
> > Add a new variable that counts the combined (insn+symbol) line count and
> > report this in the error message.
>
> This looks good to me. Thanks!
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks!
So what is the status on this one? Is there someone here who can take it
through their tree s.t. it might make it into 6.10-rc1 or 6.11-rc1?
- Best Valentin
>
> >
> > Fixes: 35039eb6b199 ("x86: Show symbol name if insn decoder test failed")
> > Cc: stable@vger.kernel.org
> > Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
> > Tested-by: Miguel Ojeda <ojeda@kernel.org>
> > Reported-by: John Baublitz <john.m.baublitz@gmail.com>
> > Debugged-by: John Baublitz <john.m.baublitz@gmail.com>
> > Signed-off-by: Valentin Obst <kernel@valentinobst.de>
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2024-05-15 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 11:31 [PATCH v3] x86/tools: fix line number reported for malformed lines Valentin Obst
2024-04-03 0:17 ` Masami Hiramatsu
2024-05-15 18:17 ` Valentin Obst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515181716.3313-1-kernel@valentinobst.de \
--to=kernel@valentinobst.de \
--cc=a.hindborg@samsung.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=john.m.baublitz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=sergio.collado@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).