From: Greg KH <gregkh@linuxfoundation.org>
To: Edward Liaw <edliaw@google.com>
Cc: stable@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
kernel-team@android.com, Mark Brown <broonie@kernel.org>,
Kees Cook <keescook@chromium.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6.6.y] kselftest: Add a ksft_perror() helper
Date: Wed, 15 May 2024 09:26:37 +0200 [thread overview]
Message-ID: <2024051505-french-spoiled-d23c@gregkh> (raw)
In-Reply-To: <CAG4es9VL8CdROKVygYi3YAo3ZuugXgiyt6uhf+3yq6s8iKfQeg@mail.gmail.com>
On Tue, Apr 30, 2024 at 10:29:43AM -0700, Edward Liaw wrote:
> On Tue, Apr 30, 2024 at 12:51 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Apr 30, 2024 at 01:06:27AM +0000, Edward Liaw wrote:
> > > From: Mark Brown <broonie@kernel.org>
> > >
> > > [ Upstream commit 907f33028871fa7c9a3db1efd467b78ef82cce20 ]
> > >
> > > The standard library perror() function provides a convenient way to print
> > > an error message based on the current errno but this doesn't play nicely
> > > with KTAP output. Provide a helper which does an equivalent thing in a KTAP
> > > compatible format.
> > >
> > > nolibc doesn't have a strerror() and adding the table of strings required
> > > doesn't seem like a good fit for what it's trying to do so when we're using
> > > that only print the errno.
> > >
> > > Signed-off-by: Mark Brown <broonie@kernel.org>
> > > Reviewed-by: Kees Cook <keescook@chromium.org>
> > > Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> > > Stable-dep-of: 071af0c9e582 ("selftests: timers: Convert posix_timers test to generate KTAP output")
> > > Signed-off-by: Edward Liaw <edliaw@google.com>
> > > ---
> > > tools/testing/selftests/kselftest.h | 14 ++++++++++++++
> > > 1 file changed, 14 insertions(+)
> >
> > This commit is already in 6.6.29, why submit it again?
>
> Hi Greg,
> I double checked and I don't see this commit in 6.6.29. As far as I
> can tell the earliest it has been merged is in 6.7.1. Do you mind
> rechecking?
My fault, yes, you are right, it is not in 6.6.y, I don't know what I
was looking at.
Can you resubmit it if it really is needed there?
thanks,
greg k-h
next prev parent reply other threads:[~2024-05-15 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 1:06 [PATCH 6.6.y] kselftest: Add a ksft_perror() helper Edward Liaw
2024-04-30 7:51 ` Greg KH
2024-04-30 17:29 ` Edward Liaw
2024-05-15 7:26 ` Greg KH [this message]
2024-04-30 17:31 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024051505-french-spoiled-d23c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=edliaw@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).