From: Jeremy Bongio <bongiojp@gmail.com>
To: stable@vger.kernel.org
Cc: Li Nan <linan122@huawei.com>, Song Liu <song@kernel.org>,
Jeremy Bongio <jbongio@google.com>
Subject: [PATCH] md: fix kmemleak of rdev->serial
Date: Mon, 13 May 2024 14:39:38 -0700 [thread overview]
Message-ID: <20240513213938.626201-1-bongiojp@gmail.com> (raw)
From: Li Nan <linan122@huawei.com>
commit 6cf350658736681b9d6b0b6e58c5c76b235bb4c4 upstream.
If kobject_add() is fail in bind_rdev_to_array(), 'rdev->serial' will be
alloc not be freed, and kmemleak occurs.
unreferenced object 0xffff88815a350000 (size 49152):
comm "mdadm", pid 789, jiffies 4294716910
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace (crc f773277a):
[<0000000058b0a453>] kmemleak_alloc+0x61/0xe0
[<00000000366adf14>] __kmalloc_large_node+0x15e/0x270
[<000000002e82961b>] __kmalloc_node.cold+0x11/0x7f
[<00000000f206d60a>] kvmalloc_node+0x74/0x150
[<0000000034bf3363>] rdev_init_serial+0x67/0x170
[<0000000010e08fe9>] mddev_create_serial_pool+0x62/0x220
[<00000000c3837bf0>] bind_rdev_to_array+0x2af/0x630
[<0000000073c28560>] md_add_new_disk+0x400/0x9f0
[<00000000770e30ff>] md_ioctl+0x15bf/0x1c10
[<000000006cfab718>] blkdev_ioctl+0x191/0x3f0
[<0000000085086a11>] vfs_ioctl+0x22/0x60
[<0000000018b656fe>] __x64_sys_ioctl+0xba/0xe0
[<00000000e54e675e>] do_syscall_64+0x71/0x150
[<000000008b0ad622>] entry_SYSCALL_64_after_hwframe+0x6c/0x74
backport change:
mddev_destroy_serial_pool third parameter was removed in mainline,
where there is no need to suspend within this function anymore.
Fixes: 963c555e75b0 ("md: introduce mddev_create/destroy_wb_pool for the change of member device")
Signed-off-by: Li Nan <linan122@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20240208085556.2412922-1-linan666@huaweicloud.com
Change-Id: Icc4960dcaffedc663797e2d8b18a24c23e201932
Signed-off-by: Jeremy Bongio <jbongio@google.com>
---
drivers/md/md.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 09c7f52156f3f..67ceab4573be4 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -2532,6 +2532,7 @@ static int bind_rdev_to_array(struct md_rdev *rdev, struct mddev *mddev)
fail:
pr_warn("md: failed to register dev-%s for %s\n",
b, mdname(mddev));
+ mddev_destroy_serial_pool(mddev, rdev, false);
return err;
}
--
2.45.0.118.g7fe29c98d7-goog
next reply other threads:[~2024-05-13 21:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 21:39 Jeremy Bongio [this message]
2024-05-13 22:24 ` [PATCH] md: fix kmemleak of rdev->serial Greg KH
2024-05-13 23:31 ` Jeremy Bongio
-- strict thread matches above, loose matches on Subject: below --
2024-05-13 23:30 Jeremy Bongio
2024-05-15 7:33 ` Greg KH
2024-05-15 16:31 ` Jeremy Bongio
2024-05-16 6:54 ` Greg KH
2024-05-20 22:18 ` Jeremy Bongio
2024-05-13 19:20 Jeremy Bongio
2024-05-13 20:53 ` Greg KH
2024-05-13 19:20 Jeremy Bongio
2024-05-13 20:53 ` Greg KH
2024-05-13 21:40 ` Jeremy Bongio
2024-05-13 20:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513213938.626201-1-bongiojp@gmail.com \
--to=bongiojp@gmail.com \
--cc=jbongio@google.com \
--cc=linan122@huawei.com \
--cc=song@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).