From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: <UNGLinuxDriver@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Allan Nielsen <allan.nielsen@microchip.com>,
Steen Hegelund <steen.hegelund@microchip.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH net v2] net: lan966x: remove debugfs directory in probe() error path
Date: Mon, 13 May 2024 13:44:07 +0200 [thread overview]
Message-ID: <20240513114407.t2iqcx7txoxkbnlj@DEN-DL-M31836.microchip.com> (raw)
In-Reply-To: <20240513111853.58668-1-herve.codina@bootlin.com>
Hi,
The 05/13/2024 13:18, Herve Codina wrote:
>
> A debugfs directory entry is create early during probe(). This entry is
> not removed on error path leading to some "already present" issues in
> case of EPROBE_DEFER.
>
> Create this entry later in the probe() code to avoid the need to change
> many 'return' in 'goto' and add the removal in the already present error
> path.
>
> Fixes: 942814840127 ("net: lan966x: Add VCAP debugFS support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
This looks OK to me. As the debugfs_root is used inside lan966x_vcap_init
which is called at the end of the probe.
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> index 2635ef8958c8..61d88207eed4 100644
> --- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> @@ -1087,8 +1087,6 @@ static int lan966x_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, lan966x);
> lan966x->dev = &pdev->dev;
>
> - lan966x->debugfs_root = debugfs_create_dir("lan966x", NULL);
> -
> if (!device_get_mac_address(&pdev->dev, mac_addr)) {
> ether_addr_copy(lan966x->base_mac, mac_addr);
> } else {
> @@ -1179,6 +1177,8 @@ static int lan966x_probe(struct platform_device *pdev)
> return dev_err_probe(&pdev->dev, -ENODEV,
> "no ethernet-ports child found\n");
>
> + lan966x->debugfs_root = debugfs_create_dir("lan966x", NULL);
> +
> /* init switch */
> lan966x_init(lan966x);
> lan966x_stats_init(lan966x);
> @@ -1257,6 +1257,8 @@ static int lan966x_probe(struct platform_device *pdev)
> destroy_workqueue(lan966x->stats_queue);
> mutex_destroy(&lan966x->stats_lock);
>
> + debugfs_remove_recursive(lan966x->debugfs_root);
> +
> return err;
> }
>
> --
>
> This patch was previously sent as part of a bigger series:
> https://lore.kernel.org/lkml/20240430083730.134918-9-herve.codina@bootlin.com/
> As it is a simple fix, this v2 is the patch extracted from the series
> and sent alone to net.
>
> Changes v1 -> v2
> Add 'Reviewed-by: Andrew Lunn <andrew@lunn.ch>'
>
> 2.44.0
--
/Horatiu
next prev parent reply other threads:[~2024-05-13 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 11:18 [PATCH net v2] net: lan966x: remove debugfs directory in probe() error path Herve Codina
2024-05-13 11:44 ` Horatiu Vultur [this message]
2024-05-16 8:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513114407.t2iqcx7txoxkbnlj@DEN-DL-M31836.microchip.com \
--to=horatiu.vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herve.codina@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=steen.hegelund@microchip.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).