From: Andreas Larsson <andreas@gaisler.com>
To: Thorsten Blum <thorsten.blum@toblux.com>,
"David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc: Compare pointers to NULL instead of 0
Date: Mon, 22 Apr 2024 16:43:56 +0200 [thread overview]
Message-ID: <be681d47-81d4-470a-bdf2-d147d0cd4789@gaisler.com> (raw)
In-Reply-To: <20240404192932.13075-2-thorsten.blum@toblux.com>
On 2024-04-04 21:29, Thorsten Blum wrote:
> Fixes the following two Coccinelle/coccicheck warnings reported by
> badzero.cocci:
>
> WARNING comparing pointer to 0
> WARNING comparing pointer to 0
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> arch/sparc/prom/tree_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/prom/tree_64.c b/arch/sparc/prom/tree_64.c
> index 989e7992d629..88793e5b0ab5 100644
> --- a/arch/sparc/prom/tree_64.c
> +++ b/arch/sparc/prom/tree_64.c
> @@ -332,7 +332,7 @@ prom_setprop(phandle node, const char *pname, char *value, int size)
>
> if (size == 0)
> return 0;
> - if ((pname == 0) || (value == 0))
> + if ((pname == NULL) || (value == NULL))
> return 0;
>
> #ifdef CONFIG_SUN_LDOMS
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Picking this up to my for-next
Thanks,
Andreas
prev parent reply other threads:[~2024-04-22 14:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 19:29 [PATCH] sparc: Compare pointers to NULL instead of 0 Thorsten Blum
2024-04-22 14:43 ` Andreas Larsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be681d47-81d4-470a-bdf2-d147d0cd4789@gaisler.com \
--to=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=thorsten.blum@toblux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).