From: Andreas Larsson <andreas@gaisler.com>
To: Markus Elfring <Markus.Elfring@web.de>,
sparclinux@vger.kernel.org, kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>, Sam Ravnborg <sam@ravnborg.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] sparc: leon: grpci1: Use devm_platform_ioremap_resource() in grpci1_of_probe()
Date: Fri, 16 Feb 2024 17:45:21 +0100 [thread overview]
Message-ID: <bbab8a40-ba76-42f5-8f8f-2259ce70e14e@gaisler.com> (raw)
In-Reply-To: <e4585b03-3629-4bd7-a349-f5471ebd8685@web.de>
On 2024-02-06 16:40, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 6 Feb 2024 16:30:15 +0100
>
> A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42
This line is needlessly long. Could you wrap it or shorten the SHA-1 ID?
You don't need more than the first 12 characters of the SHA-1 ID.
> ("drivers: provide devm_platform_ioremap_resource()").
>
> * Thus reuse existing functionality instead of keeping duplicate source code.
The same goes for this one. Please keep the width of the commit
description within 75 characters.
> * Delete a local variable which became unnecessary with this refactoring.
>
>
> This issue was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Apart from that the patch looks good.
Thanks,
Andreas
prev parent reply other threads:[~2024-02-16 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 20:36 [PATCH] sparc: leon: grpci1: Use devm_platform_get_and_ioremap_resource() in grpci1_of_probe() Markus Elfring
2024-02-06 15:40 ` [PATCH v2] sparc: leon: grpci1: Use devm_platform_ioremap_resource() " Markus Elfring
2024-02-16 16:45 ` Andreas Larsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbab8a40-ba76-42f5-8f8f-2259ce70e14e@gaisler.com \
--to=andreas@gaisler.com \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).